bug #57594 [String] Normalize underscores in snake() (xabbuh)

nicolas-grekas · nicolas-grekas · commit 4e57b84cd3d2 · 2024-06-29T07:35:41.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [String] Normalize underscores in snake() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57497 (comment) | License | MIT Commits ------- 0e6cd07 normalize underscores in snake()
diff --git a/src/Symfony/Component/String/AbstractUnicodeString.php b/src/Symfony/Component/String/AbstractUnicodeString.php
@@ -367,7 +367,7 @@ public function reverse(): parent
     public function snake(): parent
     {
         $str = clone $this;
-        $str->string = str_replace(' ', '_', mb_strtolower(preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1 \2', $str->string), 'UTF-8'));
+        $str->string = preg_replace('/[ _]+/', '_', mb_strtolower(preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1 \2', $str->string), 'UTF-8'));
 
         return $str;
     }
diff --git a/src/Symfony/Component/String/ByteString.php b/src/Symfony/Component/String/ByteString.php
@@ -367,7 +367,7 @@ public function slice(int $start = 0, ?int $length = null): parent
     public function snake(): parent
     {
         $str = clone $this;
-        $str->string = str_replace(' ', '_', strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1 \2', $str->string)));
+        $str->string = preg_replace('/[ _]+/', '_', strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1 \2', $str->string)));
 
         return $str;
     }
diff --git a/src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php b/src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php
@@ -1079,6 +1079,9 @@ public static function provideSnake()
             ['symfony', 'SYMFONY'],
             ['symfony_is_great', 'SYMFONY IS GREAT'],
             ['symfony_is_great', 'SYMFONY_IS_GREAT'],
+            ['symfony_is_great', 'symfony    is     great'],
+            ['symfony_is_great', 'SYMFONY    IS     GREAT'],
+            ['symfony_is_great', 'SYMFONY _ IS _ GREAT'],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ public function reverse(): parent`
`367`	`367`	`public function snake(): parent`
`368`	`368`	`{`
`369`	`369`	`$str = clone $this;`
`370`		`- $str->string = str_replace(' ', '_', mb_strtolower(preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1 \2', $str->string), 'UTF-8'));`
	`370`	`+ $str->string = preg_replace('/[ _]+/', '_', mb_strtolower(preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1 \2', $str->string), 'UTF-8'));`
`371`	`371`
`372`	`372`	`return $str;`
`373`	`373`	`}`
Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ public function slice(int $start = 0, ?int $length = null): parent`
`367`	`367`	`public function snake(): parent`
`368`	`368`	`{`
`369`	`369`	`$str = clone $this;`
`370`		`- $str->string = str_replace(' ', '_', strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1 \2', $str->string)));`
	`370`	`+ $str->string = preg_replace('/[ _]+/', '_', strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1 \2', $str->string)));`
`371`	`371`
`372`	`372`	`return $str;`
`373`	`373`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1079,6 +1079,9 @@ public static function provideSnake()`
`1079`	`1079`	`['symfony', 'SYMFONY'],`
`1080`	`1080`	`['symfony_is_great', 'SYMFONY IS GREAT'],`
`1081`	`1081`	`['symfony_is_great', 'SYMFONY_IS_GREAT'],`
	`1082`	`+ ['symfony_is_great', 'symfony is great'],`
	`1083`	`+ ['symfony_is_great', 'SYMFONY IS GREAT'],`
	`1084`	`+ ['symfony_is_great', 'SYMFONY _ IS _ GREAT'],`
`1082`	`1085`	`];`
`1083`	`1086`	`}`
`1084`	`1087`