[BrowserKit] Adds support for meta refresh

jhedstrom · jhedstrom · commit 4f443ee47fbd · 2018-05-01T16:24:04.000-07:00
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -367,7 +367,18 @@ public function request(string $method, string $uri, array $parameters = array()
             return $this->crawler = $this->followRedirect();
         }
 
-        return $this->crawler = $this->createCrawlerFromContent($this->internalRequest->getUri(), $this->internalResponse->getContent(), $this->internalResponse->getHeader('Content-Type'));
+        $this->crawler = $this->createCrawlerFromContent($this->internalRequest->getUri(), $this->internalResponse->getContent(), $this->internalResponse->getHeader('Content-Type'));
+
+        if ($this->followRedirects) {
+            // Check for meta refresh redirect.
+            $redirect = $this->hasMetaRefresh();
+            if ($redirect) {
+                $this->redirect = $redirect;
+                $this->crawler = $this->followRedirect();
+            }
+        }
+
+        return $this->crawler;
     }
 
     /**
@@ -563,6 +574,23 @@ public function followRedirect()
         return $response;
     }
 
+    /**
+     * Determines if the response has a meta refresh.
+     *
+     * @return string|false Redirect URI if response has a meta refresh
+     */
+    protected function hasMetaRefresh()
+    {
+        $url = false;
+        $metaRefresh = $this->getCrawler()->filter('head meta[http-equiv="refresh"]');
+        $content = $metaRefresh->extract(array('content'));
+        if (!empty($content) && preg_match('/.*URL=(.*)$/i', $content[0], $m)) {
+            $url = $m[1];
+        }
+
+        return $url;
+    }
+
     /**
      * Restarts the client.
      *
diff --git a/src/Symfony/Component/BrowserKit/Tests/ClientTest.php b/src/Symfony/Component/BrowserKit/Tests/ClientTest.php
@@ -594,6 +594,15 @@ public function testFollowRedirectDropPostMethod()
         }
     }
 
+    public function testFollowMetaRefresh()
+    {
+        $content = '<html><head><meta http-equiv="refresh" content="0; URL=http://www.example.com/redirected"/></head></html>';
+        $client = new TestClient();
+        $client->setNextResponse(new Response($content));
+        $client->request('GET', 'http://www.example.com/foo/foobar');
+        $this->assertEquals('http://www.example.com/redirected', $client->getRequest()->getUri());
+    }
+
     public function testBack()
     {
         $client = new TestClient();

Original file line number	Diff line number	Diff line change
`@@ -594,6 +594,15 @@ public function testFollowRedirectDropPostMethod()`
`594`	`594`	`}`
`595`	`595`	`}`
`596`	`596`
	`597`	`+ public function testFollowMetaRefresh()`
	`598`	`+ {`
	`599`	`+ $content = '<html><head><meta http-equiv="refresh" content="0; URL=http://www.example.com/redirected"/></head></html>';`
	`600`	`+ $client = new TestClient();`
	`601`	`+ $client->setNextResponse(new Response($content));`
	`602`	`+ $client->request('GET', 'http://www.example.com/foo/foobar');`
	`603`	`+ $this->assertEquals('http://www.example.com/redirected', $client->getRequest()->getUri());`
	`604`	`+ }`
	`605`	`+`
`597`	`606`	`public function testBack()`
`598`	`607`	`{`
`599`	`608`	`$client = new TestClient();`