[Event Dispatcher] fixed 29703: TraceableEventDispatcher reset now sets callStack to null with test to dispatch after reset.

mlievertz · mlievertz · commit 51bcdb8dc38b · 2018-12-28T07:55:37.000-05:00
diff --git a/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php b/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
@@ -221,7 +221,7 @@ public function getNotCalledListeners()
 
     public function reset()
     {
-        $this->callStack = array();
+        $this->callStack = null;
     }
 
     /**
diff --git a/src/Symfony/Component/EventDispatcher/Tests/Debug/TraceableEventDispatcherTest.php b/src/Symfony/Component/EventDispatcher/Tests/Debug/TraceableEventDispatcherTest.php
@@ -139,6 +139,18 @@ public function testClearCalledListeners()
         $this->assertEquals(array(array('event' => 'foo', 'pretty' => 'closure', 'priority' => 5)), $listeners);
     }
 
+    public function testDispatchAfterReset()
+    {
+        $tdispatcher = new TraceableEventDispatcher(new EventDispatcher(), new Stopwatch());
+        $tdispatcher->addListener('foo', function () {}, 5);
+
+        $tdispatcher->reset();
+        $tdispatcher->dispatch('foo');
+
+        $listeners = $tdispatcher->getCalledListeners();
+        $this->assertArrayHasKey('stub', $listeners[0]);
+    }
+
     public function testGetCalledListenersNested()
     {
         $tdispatcher = null;

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ public function getNotCalledListeners()`
`221`	`221`
`222`	`222`	`public function reset()`
`223`	`223`	`{`
`224`		`- $this->callStack = array();`
	`224`	`+ $this->callStack = null;`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`/**`