minor #36892 [Debug] Skip test that would trigger a fatal error on php 8 (derrabus)

nicolas-grekas · nicolas-grekas · commit 52abcbeec969 · 2020-05-22T10:14:52.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Skip test that would trigger a fatal error on php 8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A This PR skips a test of `DebugClassLoader`. The test uses incompatible method signatures in class inheritance to provoke a php warning that should be handled by the debug class loader. On php 8 however, this error is not recoverable anymore, so the tested logic will be obsolete there. Commits ------- 573d0dd [Debug] Skip test that would trigger a fatal error on php 8.
diff --git a/src/Symfony/Component/Debug/Tests/DebugClassLoaderTest.php b/src/Symfony/Component/Debug/Tests/DebugClassLoaderTest.php
@@ -97,6 +97,9 @@ public function testUnsilencing()
         $this->assertStringMatchesFormat('%aParse error%a', $output);
     }
 
+    /**
+     * @requires PHP < 8.0
+     */
     public function testStacking()
     {
         // the ContextErrorException must not be loaded to test the workaround

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,9 @@ public function testUnsilencing()`
`97`	`97`	`$this->assertStringMatchesFormat('%aParse error%a', $output);`
`98`	`98`	`}`
`99`	`99`
	`100`	`+ /**`
	`101`	`+ * @requires PHP < 8.0`
	`102`	`+ */`
`100`	`103`	`public function testStacking()`
`101`	`104`	`{`
`102`	`105`	`// the ContextErrorException must not be loaded to test the workaround`