Fix dump panel hidden when closing a dump

julienfalque · julienfalque · commit 55a7515806ee · 2017-10-25T00:54:07.000+02:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig
@@ -58,6 +58,18 @@
                         }
                     };
                 }
+
+                var dumpInfo = document.querySelector('.sf-toolbar-block-dump .sf-toolbar-info');
+                if (null !== dumpInfo) {
+                    Sfjs.addEventListener(dumpInfo, 'sfbeforedumptoggle', function (event) {
+                        if (!event.detail.expanding) {
+                            dumpInfo.style.minHeight = dumpInfo.getBoundingClientRect().height+'px';
+                        }
+                    });
+                    Sfjs.addEventListener(dumpInfo, 'mouseleave', function () {
+                        dumpInfo.style.minHeight = '';
+                    });
+                }
             },
             function(xhr) {
                 if (xhr.status !== 0) {
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -130,17 +130,24 @@ protected function getDumpHeader()
 }
 
 function toggle(a, recursive) {
-    var s = a.nextSibling || {}, oldClass = s.className, arrow, newClass;
+    var s = a.nextSibling || {}, oldClass = s.className, arrow, newClass, expanding;
 
     if (/\bsf-dump-compact\b/.test(oldClass)) {
         arrow = '▼';
         newClass = 'sf-dump-expanded';
+        expanding = true;
     } else if (/\bsf-dump-expanded\b/.test(oldClass)) {
         arrow = '▶';
         newClass = 'sf-dump-compact';
+        expanding = false;
     } else {
         return false;
     }
+    
+    s.dispatchEvent(new CustomEvent('sfbeforedumptoggle', {
+        detail: { expanding: expanding },
+        bubbles: true
+    }));
 
     a.lastChild.innerHTML = arrow;
     s.className = s.className.replace(/\bsf-dump-(compact|expanded)\b/, newClass);
