Get rid of "remaining" prefix

greg0ire · greg0ire · commit 5782a1e1fc72 · 2020-01-27T23:06:37.000+01:00
If people elected to ignore a deprecation group, it makes no sense to
have this prefix
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
@@ -284,11 +284,7 @@ private function displayDeprecations($groups, $configuration, $isFailing)
         foreach ($groups as $group) {
             if ($this->deprecationGroups[$group]->count()) {
                 echo "\n", self::colorize(
-                    sprintf(
-                        '%s deprecation notices (%d)',
-                        \in_array($group, ['direct', 'indirect', 'self'], true) ? "Remaining $group" : ucfirst($group),
-                        $this->deprecationGroups[$group]->count()
-                    ),
+                    sprintf('%s deprecation notices (%d)', ucfirst($group), $this->deprecationGroups[$group]->count()),
                     'legacy' !== $group && 'indirect' !== $group
                 ), "\n";
 
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/lagging_vendor.phpt b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/lagging_vendor.phpt
@@ -33,7 +33,7 @@ require __DIR__.'/fake_vendor/acme/outdated-lib/outdated_file.php';
 
 ?>
 --EXPECTF--
-Remaining indirect deprecation notices (1)
+Indirect deprecation notices (1)
 
   1x: deprecatedApi is deprecated! You should stop relying on it!
     1x in SomeService::deprecatedApi from acme\lib
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/partially_quiet.phpt b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/partially_quiet.phpt
@@ -24,9 +24,9 @@ require __DIR__.'/fake_vendor/acme/outdated-lib/outdated_file.php';
 --EXPECTF--
 Unsilenced deprecation notices (3)
 
-Remaining direct deprecation notices (1)
+Direct deprecation notices (1)
 
-Remaining indirect deprecation notices (1)
+Indirect deprecation notices (1)
 
   1x: deprecatedApi is deprecated! You should stop relying on it!
     1x in SomeService::deprecatedApi from acme\lib
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/quiet_but_failing.phpt b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/quiet_but_failing.phpt
@@ -33,7 +33,7 @@ require __DIR__.'/fake_vendor/acme/outdated-lib/outdated_file.php';
 
 ?>
 --EXPECTF--
-Remaining indirect deprecation notices (1)
+Indirect deprecation notices (1)
 
   1x: deprecatedApi is deprecated! You should stop relying on it!
     1x in SomeService::deprecatedApi from acme\lib
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/weak_vendors_on_vendor.phpt b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/weak_vendors_on_vendor.phpt
@@ -29,7 +29,7 @@ Unsilenced deprecation notices (3)
   1x: unsilenced bar deprecation
     1x in FooTestCase::testNonLegacyBar
 
-Remaining direct deprecation notices (1)
+Direct deprecation notices (1)
 
   1x: silenced bar deprecation
     1x in FooTestCase::testNonLegacyBar
