fixup deprecations visibilty in bags

HeahDude · HeahDude · commit 5b8f8112b863 · 2022-10-22T12:39:57.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/ParameterBag/FrozenParameterBag.php b/src/Symfony/Component/DependencyInjection/ParameterBag/FrozenParameterBag.php
@@ -25,12 +25,10 @@ class FrozenParameterBag extends ParameterBag
      * all keys are already lowercased.
      *
      * This is always the case when used internally.
-     *
-     * @param array $parameters An array of parameters
      */
     public function __construct(
         array $parameters = [],
-        protected array $deprecatedParameters = [],
+        private array $deprecatedParameters = [],
     ) {
         $this->parameters = $parameters;
         $this->resolved = true;
@@ -60,4 +58,9 @@ public function remove(string $name)
     {
         throw new LogicException('Impossible to call remove() on a frozen ParameterBag.');
     }
+
+    public function allDeprecated(): array
+    {
+        return $this->deprecatedParameters;
+    }
 }
diff --git a/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php b/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php
@@ -23,8 +23,8 @@
 class ParameterBag implements ParameterBagInterface
 {
     protected $parameters = [];
-    protected array $deprecatedParameters = [];
     protected $resolved = false;
+    private array $deprecatedParameters = [];
 
     public function __construct(array $parameters = [])
     {

Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,10 @@ class FrozenParameterBag extends ParameterBag`
`25`	`25`	`* all keys are already lowercased.`
`26`	`26`	`*`
`27`	`27`	`* This is always the case when used internally.`
`28`		`- *`
`29`		`- * @param array $parameters An array of parameters`
`30`	`28`	`*/`
`31`	`29`	`public function __construct(`
`32`	`30`	`array $parameters = [],`
`33`		`- protected array $deprecatedParameters = [],`
	`31`	`+ private array $deprecatedParameters = [],`
`34`	`32`	`) {`
`35`	`33`	`$this->parameters = $parameters;`
`36`	`34`	`$this->resolved = true;`
`@@ -60,4 +58,9 @@ public function remove(string $name)`
`60`	`58`	`{`
`61`	`59`	`throw new LogicException('Impossible to call remove() on a frozen ParameterBag.');`
`62`	`60`	`}`
	`61`	`+`
	`62`	`+ public function allDeprecated(): array`
	`63`	`+ {`
	`64`	`+ return $this->deprecatedParameters;`
	`65`	`+ }`
`63`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@`
`23`	`23`	`class ParameterBag implements ParameterBagInterface`
`24`	`24`	`{`
`25`	`25`	`protected $parameters = [];`
`26`		`- protected array $deprecatedParameters = [];`
`27`	`26`	`protected $resolved = false;`
	`27`	`+ private array $deprecatedParameters = [];`
`28`	`28`
`29`	`29`	`public function __construct(array $parameters = [])`
`30`	`30`	`{`