[Security][Http] Add type-hints

andreia · andreia · commit 5dcb38106157 · 2019-08-03T23:21:58.000-03:00
diff --git a/src/Symfony/Component/Security/Http/AccessMap.php b/src/Symfony/Component/Security/Http/AccessMap.php
@@ -29,7 +29,7 @@ class AccessMap implements AccessMapInterface
      * @param array                   $attributes     An array of attributes to pass to the access decision manager (like roles)
      * @param string|null             $channel        The channel to enforce (http, https, or null)
      */
-    public function add(RequestMatcherInterface $requestMatcher, array $attributes = [], ?string $channel = null)
+    public function add(RequestMatcherInterface $requestMatcher, array $attributes = [], string $channel = null)
     {
         $this->map[] = [$requestMatcher, $attributes, $channel];
     }
diff --git a/src/Symfony/Component/Security/Http/Authentication/DefaultAuthenticationSuccessHandler.php b/src/Symfony/Component/Security/Http/Authentication/DefaultAuthenticationSuccessHandler.php
@@ -82,9 +82,6 @@ public function getProviderKey()
         return $this->providerKey;
     }
 
-    /**
-     * Set the provider key.
-     */
     public function setProviderKey(string $providerKey)
     {
         $this->providerKey = $providerKey;
diff --git a/src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php b/src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
@@ -56,8 +56,6 @@ public function registerListener($key, $logoutPath, $csrfTokenId, $csrfParameter
     /**
      * Generates the absolute logout path for the firewall.
      *
-     * @param string|null $key The firewall key or null to use the current firewall key
-     *
      * @return string The logout path
      */
     public function getLogoutPath(?string $key = null)
@@ -68,8 +66,6 @@ public function getLogoutPath(?string $key = null)
     /**
      * Generates the absolute logout URL for the firewall.
      *
-     * @param string|null $key The firewall key or null to use the current firewall key
-     *
      * @return string The logout URL
      */
     public function getLogoutUrl(?string $key = null)
diff --git a/src/Symfony/Component/Security/Http/ParameterBagUtils.php b/src/Symfony/Component/Security/Http/ParameterBagUtils.php
@@ -29,9 +29,6 @@ final class ParameterBagUtils
      *
      * Paths like foo[bar] will be evaluated to find deeper items in nested data structures.
      *
-     * @param ParameterBag $parameters The parameter bag
-     * @param string       $path       The key
-     *
      * @return mixed
      *
      * @throws InvalidArgumentException when the given path is malformed
@@ -64,9 +61,6 @@ public static function getParameterBagValue(ParameterBag $parameters, string $pa
      *
      * Paths like foo[bar] will be evaluated to find deeper items in nested data structures.
      *
-     * @param Request $request The request
-     * @param string  $path    The key
-     *
      * @return mixed
      *
      * @throws InvalidArgumentException when the given path is malformed

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class AccessMap implements AccessMapInterface`
`29`	`29`	`* @param array $attributes An array of attributes to pass to the access decision manager (like roles)`
`30`	`30`	`* @param string\|null $channel The channel to enforce (http, https, or null)`
`31`	`31`	`*/`
`32`		`- public function add(RequestMatcherInterface $requestMatcher, array $attributes = [], ?string $channel = null)`
	`32`	`+ public function add(RequestMatcherInterface $requestMatcher, array $attributes = [], string $channel = null)`
`33`	`33`	`{`
`34`	`34`	`$this->map[] = [$requestMatcher, $attributes, $channel];`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,6 @@ public function getProviderKey()`
`82`	`82`	`return $this->providerKey;`
`83`	`83`	`}`
`84`	`84`
`85`		`- /**`
`86`		`- * Set the provider key.`
`87`		`- */`
`88`	`85`	`public function setProviderKey(string $providerKey)`
`89`	`86`	`{`
`90`	`87`	`$this->providerKey = $providerKey;`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,6 @@ final class ParameterBagUtils`
`29`	`29`	`*`
`30`	`30`	`* Paths like foo[bar] will be evaluated to find deeper items in nested data structures.`
`31`	`31`	`*`
`32`		`- * @param ParameterBag $parameters The parameter bag`
`33`		`- * @param string $path The key`
`34`		`- *`
`35`	`32`	`* @return mixed`
`36`	`33`	`*`
`37`	`34`	`* @throws InvalidArgumentException when the given path is malformed`
`@@ -64,9 +61,6 @@ public static function getParameterBagValue(ParameterBag $parameters, string $pa`
`64`	`61`	`*`
`65`	`62`	`* Paths like foo[bar] will be evaluated to find deeper items in nested data structures.`
`66`	`63`	`*`
`67`		`- * @param Request $request The request`
`68`		`- * @param string $path The key`
`69`		`- *`
`70`	`64`	`* @return mixed`
`71`	`65`	`*`
`72`	`66`	`* @throws InvalidArgumentException when the given path is malformed`