bug #36121 [VarDumper] fix side-effect by not using mt_rand() (nicolas-grekas)

fabpot · fabpot · commit 5f364af6a0c5 · 2020-03-18T08:13:59.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] fix side-effect by not using mt_rand() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reported by @bobthecow on Twitter: using `mt_rand()` breaks inspecting seeded calls to `mt_rand()`. Should be replaced by a call to `md5(random_bytes(6))` on 4.4. Commits ------- 8c85f91 [VarDumper] fix side-effect by not using mt_rand()
diff --git a/src/Symfony/Component/VarDumper/Cloner/VarCloner.php b/src/Symfony/Component/VarDumper/Cloner/VarCloner.php
@@ -48,8 +48,8 @@ protected function doClone($var)
                                         // or null if the original value is used directly
 
         if (!self::$hashMask) {
-            self::$gid = uniqid(mt_rand(), true); // Unique string used to detect the special $GLOBALS variable
             self::initHashMask();
+            self::$gid = md5(dechex(self::$hashMask)); // Unique string used to detect the special $GLOBALS variable
         }
         $gid = self::$gid;
         $hashMask = self::$hashMask;

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ protected function doClone($var)`
`48`	`48`	`// or null if the original value is used directly`
`49`	`49`
`50`	`50`	`if (!self::$hashMask) {`
`51`		`- self::$gid = uniqid(mt_rand(), true); // Unique string used to detect the special $GLOBALS variable`
`52`	`51`	`self::initHashMask();`
	`52`	`+ self::$gid = md5(dechex(self::$hashMask)); // Unique string used to detect the special $GLOBALS variable`
`53`	`53`	`}`
`54`	`54`	`$gid = self::$gid;`
`55`	`55`	`$hashMask = self::$hashMask;`