[Form][PhpUnitBridge] Remove usage of noop ReflectionProperty::setAccessible()

NickSdot · nicolas-grekas · commit 5f69f0faa227 · 2025-07-24T10:25:04.000+02:00
diff --git a/src/Symfony/Bridge/PhpUnit/CoverageListener.php b/src/Symfony/Bridge/PhpUnit/CoverageListener.php
@@ -86,7 +86,6 @@ public function startTest(Test $test): void
     private function addCoversForClassToAnnotationCache(Test $test, array $covers): void
     {
         $r = new \ReflectionProperty(TestUtil::class, 'annotationCache');
-        $r->setAccessible(true);
 
         $cache = $r->getValue();
         $cache = array_replace_recursive($cache, [
@@ -103,7 +102,6 @@ private function addCoversForDocBlockInsideRegistry(Test $test, array $covers):
         $docBlock = Registry::getInstance()->forClassName(\get_class($test));
 
         $symbolAnnotations = new \ReflectionProperty($docBlock, 'symbolAnnotations');
-        $symbolAnnotations->setAccessible(true);
 
         // Exclude internal classes; PHPUnit 9.1+ is picky about tests covering, say, a \RuntimeException
         $covers = array_filter($covers, function (string $class) {
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
@@ -437,7 +437,6 @@ public function toString()
     {
         $exception = new \Exception($this->message);
         $reflection = new \ReflectionProperty($exception, 'trace');
-        $reflection->setAccessible(true);
         $reflection->setValue($exception, $this->trace);
 
         return ($this->originatesFromAnObject() ? 'deprecation triggered by '.$this->originatingClass().'::'.$this->originatingMethod().":\n" : '')
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
@@ -357,7 +357,6 @@ private function willBeIsolated(TestCase $test): bool
         }
 
         $r = new \ReflectionProperty($test, 'runTestInSeparateProcess');
-        $r->setAccessible(true);
 
         return $r->getValue($test) ?? false;
     }
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php
@@ -275,7 +275,6 @@ public static function setUpBeforeClass(): void
                     $loader = require $v.'/autoload.php';
                     $reflection = new \ReflectionClass($loader);
                     $prop = $reflection->getProperty('prefixDirsPsr4');
-                    $prop->setAccessible(true);
                     $currentValue = $prop->getValue($loader);
                     self::$prefixDirsPsr4[] = [$prop, $loader, $currentValue];
                     $currentValue['Symfony\\Bridge\\PhpUnit\\'] = [realpath(__DIR__.'/../..')];
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -420,7 +420,6 @@ public function testGetEnvDoesNotAutoCastNullWithDefaultEnvVarProcessor()
         $container->compile();
 
         $r = new \ReflectionMethod($container, 'getEnv');
-        $r->setAccessible(true);
         $this->assertNull($r->invoke($container, 'FOO'));
     }
 
@@ -436,7 +435,6 @@ public function testGetEnvDoesNotAutoCastNullWithEnvVarProcessorsLocatorReturnin
         $container->compile();
 
         $r = new \ReflectionMethod($container, 'getEnv');
-        $r->setAccessible(true);
         $this->assertNull($r->invoke($container, 'FOO'));
     }
 }
diff --git a/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php b/src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php
@@ -34,7 +34,6 @@ class ErrorHandlerTest extends TestCase
     protected function tearDown(): void
     {
         $r = new \ReflectionProperty(ErrorHandler::class, 'exitCode');
-        $r->setAccessible(true);
         $r->setValue(null, 0);
     }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -754,7 +754,6 @@ public function testRoundMethodKeepsIntegersAsIntegers()
         // Use reflection to test the private round() method directly
         $reflection = new \ReflectionClass($transformer);
         $roundMethod = $reflection->getMethod('round');
-        $roundMethod->setAccessible(true);
 
         $int = \PHP_INT_MAX - 1;
         $result = $roundMethod->invoke($transformer, $int);
diff --git a/src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportTest.php b/src/Symfony/Component/Mailer/Tests/Transport/SendmailTransportTest.php
@@ -94,7 +94,6 @@ public function testThrowsTransportExceptionOnFailure()
         $sendmailTransport->send($mail, $envelope);
 
         $streamProperty = new \ReflectionProperty(SendmailTransport::class, 'stream');
-        $streamProperty->setAccessible(true);
         $stream = $streamProperty->getValue($sendmailTransport);
         $this->assertNull($stream->stream);
     }
@@ -112,10 +111,8 @@ public function testStreamIsClearedOnFailure()
         }
 
         $streamProperty = new \ReflectionProperty(SendmailTransport::class, 'stream');
-        $streamProperty->setAccessible(true);
         $stream = $streamProperty->getValue($sendmailTransport);
         $innerStreamProperty = new \ReflectionProperty(ProcessStream::class, 'stream');
-        $innerStreamProperty->setAccessible(true);
         $this->assertNull($innerStreamProperty->getValue($stream));
     }
 
@@ -127,7 +124,6 @@ public function testDoesNotThrowWhenInteractive()
 
         $sendmailTransport = new SendmailTransport(self::FAKE_INTERACTIVE_SENDMAIL);
         $transportProperty = new \ReflectionProperty(SendmailTransport::class, 'transport');
-        $transportProperty->setAccessible(true);
 
         // Replace the transport with an anonymous consumer that trigger the stream methods
         $transportProperty->setValue($sendmailTransport, new class($transportProperty->getValue($sendmailTransport)->getStream()) extends SmtpTransport {

Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,6 @@ public function toString()`
`437`	`437`	`{`
`438`	`438`	`$exception = new \Exception($this->message);`
`439`	`439`	`$reflection = new \ReflectionProperty($exception, 'trace');`
`440`		`- $reflection->setAccessible(true);`
`441`	`440`	`$reflection->setValue($exception, $this->trace);`
`442`	`441`
`443`	`442`	`return ($this->originatesFromAnObject() ? 'deprecation triggered by '.$this->originatingClass().'::'.$this->originatingMethod().":\n" : '')`
Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,6 @@ private function willBeIsolated(TestCase $test): bool`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`$r = new \ReflectionProperty($test, 'runTestInSeparateProcess');`
`360`		`- $r->setAccessible(true);`
`361`	`360`
`362`	`361`	`return $r->getValue($test) ?? false;`
`363`	`362`	`}`
Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,6 @@ public function testGetEnvDoesNotAutoCastNullWithDefaultEnvVarProcessor()`
`420`	`420`	`$container->compile();`
`421`	`421`
`422`	`422`	`$r = new \ReflectionMethod($container, 'getEnv');`
`423`		`- $r->setAccessible(true);`
`424`	`423`	`$this->assertNull($r->invoke($container, 'FOO'));`
`425`	`424`	`}`
`426`	`425`
`@@ -436,7 +435,6 @@ public function testGetEnvDoesNotAutoCastNullWithEnvVarProcessorsLocatorReturnin`
`436`	`435`	`$container->compile();`
`437`	`436`
`438`	`437`	`$r = new \ReflectionMethod($container, 'getEnv');`
`439`		`- $r->setAccessible(true);`
`440`	`438`	`$this->assertNull($r->invoke($container, 'FOO'));`
`441`	`439`	`}`
`442`	`440`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ class ErrorHandlerTest extends TestCase`
`34`	`34`	`protected function tearDown(): void`
`35`	`35`	`{`
`36`	`36`	`$r = new \ReflectionProperty(ErrorHandler::class, 'exitCode');`
`37`		`- $r->setAccessible(true);`
`38`	`37`	`$r->setValue(null, 0);`
`39`	`38`	`}`
`40`	`39`