bug #59099 [sendgrid-mailer] Fix null check on region (AUDUL)

fabpot · fabpot · commit 6076b8799ed9 · 2024-12-06T14:52:05.000+01:00
This PR was merged into the 7.2 branch. Discussion ---------- [sendgrid-mailer] Fix null check on region Fix region null check | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Issue : Nullable check on region is wrong. Commits ------- d637586 Update SendgridSmtpTransport.php
diff --git a/src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridSmtpTransport.php b/src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridSmtpTransport.php
@@ -22,7 +22,7 @@ class SendgridSmtpTransport extends EsmtpTransport
 {
     public function __construct(#[\SensitiveParameter] string $key, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null, private ?string $region = null)
     {
-        parent::__construct('null' !== $region ? \sprintf('smtp.%s.sendgrid.net', $region) : 'smtp.sendgrid.net', 465, true, $dispatcher, $logger);
+        parent::__construct(null !== $region ? \sprintf('smtp.%s.sendgrid.net', $region) : 'smtp.sendgrid.net', 465, true, $dispatcher, $logger);
 
         $this->setUsername('apikey');
         $this->setPassword($key);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class SendgridSmtpTransport extends EsmtpTransport`
`22`	`22`	`{`
`23`	`23`	`public function __construct(#[\SensitiveParameter] string $key, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null, private ?string $region = null)`
`24`	`24`	`{`
`25`		`- parent::__construct('null' !== $region ? \sprintf('smtp.%s.sendgrid.net', $region) : 'smtp.sendgrid.net', 465, true, $dispatcher, $logger);`
	`25`	`+ parent::__construct(null !== $region ? \sprintf('smtp.%s.sendgrid.net', $region) : 'smtp.sendgrid.net', 465, true, $dispatcher, $logger);`
`26`	`26`
`27`	`27`	`$this->setUsername('apikey');`
`28`	`28`	`$this->setPassword($key);`