Constraint ResponseHeaderSame now shows the actual header value

jschaedl · jschaedl · commit 621b10ec0fd2 · 2023-02-03T17:24:29.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseHeaderSame.php b/src/Symfony/Component/HttpFoundation/Test/Constraint/ResponseHeaderSame.php
@@ -18,6 +18,7 @@ final class ResponseHeaderSame extends Constraint
 {
     private string $headerName;
     private string $expectedValue;
+    private ?string $actualValue = null;
 
     public function __construct(string $headerName, string $expectedValue)
     {
@@ -27,16 +28,23 @@ public function __construct(string $headerName, string $expectedValue)
 
     public function toString(): string
     {
-        return sprintf('has header "%s" with value "%s"', $this->headerName, $this->expectedValue);
+        $output = sprintf('has header "%s" with value "%s"', $this->headerName, $this->expectedValue);
+
+        if (null !== $this->actualValue) {
+            $output .= sprintf(', value of header "%s" is "%s"', $this->headerName, $this->actualValue);
+        }
+
+        return $output;
     }
 
     /**
      * @param Response $response
      */
     protected function matches($response): bool
     {
-        return $this->expectedValue === $response->headers->get($this->headerName, null);
-    }
+        $this->actualValue = $response->headers->get($this->headerName, null);
+
+        return $this->expectedValue === $this->actualValue;}
 
     /**
      * @param Response $response
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Test/Constraint/ResponseHeaderSameTest.php b/src/Symfony/Component/HttpFoundation/Tests/Test/Constraint/ResponseHeaderSameTest.php
@@ -29,7 +29,7 @@ public function testConstraint()
         try {
             $constraint->evaluate(new Response());
         } catch (ExpectationFailedException $e) {
-            $this->assertEquals("Failed asserting that the Response has header \"Cache-Control\" with value \"public\".\n", TestFailure::exceptionToString($e));
+            $this->assertEquals("Failed asserting that the Response has header \"Cache-Control\" with value \"public\", value of header \"Cache-Control\" is \"no-cache, private\".\n", TestFailure::exceptionToString($e));
 
             return;
         }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function testConstraint()`
`29`	`29`	`try {`
`30`	`30`	`$constraint->evaluate(new Response());`
`31`	`31`	`} catch (ExpectationFailedException $e) {`
`32`		`- $this->assertEquals("Failed asserting that the Response has header \"Cache-Control\" with value \"public\".\n", TestFailure::exceptionToString($e));`
	`32`	`+ $this->assertEquals("Failed asserting that the Response has header \"Cache-Control\" with value \"public\", value of header \"Cache-Control\" is \"no-cache, private\".\n", TestFailure::exceptionToString($e));`
`33`	`33`
`34`	`34`	`return;`
`35`	`35`	`}`