Skip to content

Commit 623d149

Browse files
committed
Added a ConcreteDumper
1 parent 84f0902 commit 623d149

File tree

2 files changed

+19
-44
lines changed

2 files changed

+19
-44
lines changed

src/Symfony/Component/Translation/Dumper/NullFileDumper.php

-38
This file was deleted.

src/Symfony/Component/Translation/Tests/Dumper/NullFileDumperTest.php renamed to src/Symfony/Component/Translation/Tests/Dumper/FileDumperTest.php

+19-6
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,23 @@
1111

1212
namespace Symfony\Component\Translation\Tests\Dumper;
1313

14-
use Symfony\Component\Translation\Dumper\NullFileDumper;
1514
use Symfony\Component\Translation\MessageCatalogue;
15+
use Symfony\Component\Translation\Dumper\FileDumper;
1616

17-
class NullFileDumperTest extends \PHPUnit_Framework_TestCase
17+
class FileDumperTest extends \PHPUnit_Framework_TestCase
1818
{
1919
public function testDumpBackupsFileIfExisting()
2020
{
2121
$tempDir = sys_get_temp_dir();
22-
$file = $tempDir.'/messages.en.null';
22+
$file = $tempDir.'/messages.en.concrete';
2323
$backupFile = $file.'~';
2424

2525
@touch($file);
2626

2727
$catalogue = new MessageCatalogue('en');
2828
$catalogue->add(array('foo' => 'bar'));
2929

30-
$dumper = new NullFileDumper();
30+
$dumper = new ConcreteFileDumper();
3131
$dumper->dump($catalogue, array('path' => $tempDir));
3232

3333
$this->assertTrue(file_exists($backupFile));
@@ -40,12 +40,12 @@ public function testDumpCreatesNestedDirectoriesAndFile()
4040
{
4141
$tempDir = sys_get_temp_dir();
4242
$translationsDir = $tempDir.'/test/translations';
43-
$file = $translationsDir.'/messages.en.null';
43+
$file = $translationsDir.'/messages.en.concrete';
4444

4545
$catalogue = new MessageCatalogue('en');
4646
$catalogue->add(array('foo' => 'bar'));
4747

48-
$dumper = new NullFileDumper();
48+
$dumper = new ConcreteFileDumper();
4949
$dumper->setRelativePathTemplate('test/translations/{domain}.{locale}.{extension}');
5050
$dumper->dump($catalogue, array('path' => $tempDir));
5151

@@ -55,3 +55,16 @@ public function testDumpCreatesNestedDirectoriesAndFile()
5555
@rmdir($translationsDir);
5656
}
5757
}
58+
59+
class ConcreteFileDumper extends FileDumper
60+
{
61+
protected function format(MessageCatalogue $messages, $domain)
62+
{
63+
return '';
64+
}
65+
66+
protected function getExtension()
67+
{
68+
return 'concrete';
69+
}
70+
}

0 commit comments

Comments
 (0)