fixing legacy tests

Lctrs · Lctrs · commit 62db76a698c4 · 2025-01-22T20:28:49.000+01:00
diff --git a/src/Symfony/Component/HttpClient/Tests/LegacyCachingHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/LegacyCachingHttpClientTest.php
@@ -18,8 +18,14 @@
 use Symfony\Component\HttpKernel\HttpCache\Store;
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
+/**
+ * @group legacy
+ */
 class LegacyCachingHttpClientTest extends TestCase
 {
+    /**
+     * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.
+     */
     public function testRequestHeaders()
     {
         $options = [
@@ -41,6 +47,9 @@ public function testRequestHeaders()
         self::assertSame($response->getRequestOptions()['normalized_headers']['test-name-header'][0], 'Test-Name-Header: test12345');
     }
 
+    /**
+     * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.
+     */
     public function testDoesNotEvaluateResponseBody()
     {
         $body = file_get_contents(__DIR__.'/Fixtures/assertion_failure.php');
@@ -51,6 +60,9 @@ public function testDoesNotEvaluateResponseBody()
         $this->assertArrayNotHasKey('x-body-eval', $headers);
     }
 
+    /**
+     * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.
+     */
     public function testDoesNotIncludeFile()
     {
         $file = __DIR__.'/Fixtures/assertion_failure.php';
@@ -68,6 +80,9 @@ public function testDoesNotIncludeFile()
         $this->assertArrayNotHasKey('x-body-file', $headers);
     }
 
+    /**
+     * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.
+     */
     public function testDoesNotReadFile()
     {
         $file = __DIR__.'/Fixtures/assertion_failure.php';
@@ -83,6 +98,9 @@ public function testDoesNotReadFile()
         $this->assertArrayNotHasKey('x-body-file', $headers);
     }
 
+    /**
+     * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.
+     */
     public function testRemovesXContentDigest()
     {
         $response = $this->runRequest(new MockResponse(

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,14 @@`
`18`	`18`	`use Symfony\Component\HttpKernel\HttpCache\Store;`
`19`	`19`	`use Symfony\Contracts\HttpClient\ResponseInterface;`
`20`	`20`
	`21`	`+/**`
	`22`	`+ * @group legacy`
	`23`	`+ */`
`21`	`24`	`class LegacyCachingHttpClientTest extends TestCase`
`22`	`25`	`{`
	`26`	`+ /**`
	`27`	`+ * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.`
	`28`	`+ */`
`23`	`29`	`public function testRequestHeaders()`
`24`	`30`	`{`
`25`	`31`	`$options = [`
`@@ -41,6 +47,9 @@ public function testRequestHeaders()`
`41`	`47`	`self::assertSame($response->getRequestOptions()['normalized_headers']['test-name-header'][0], 'Test-Name-Header: test12345');`
`42`	`48`	`}`
`43`	`49`
	`50`	`+ /**`
	`51`	`+ * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.`
	`52`	`+ */`
`44`	`53`	`public function testDoesNotEvaluateResponseBody()`
`45`	`54`	`{`
`46`	`55`	`$body = file_get_contents(__DIR__.'/Fixtures/assertion_failure.php');`
`@@ -51,6 +60,9 @@ public function testDoesNotEvaluateResponseBody()`
`51`	`60`	`$this->assertArrayNotHasKey('x-body-eval', $headers);`
`52`	`61`	`}`
`53`	`62`
	`63`	`+ /**`
	`64`	`+ * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.`
	`65`	`+ */`
`54`	`66`	`public function testDoesNotIncludeFile()`
`55`	`67`	`{`
`56`	`68`	`$file = __DIR__.'/Fixtures/assertion_failure.php';`
`@@ -68,6 +80,9 @@ public function testDoesNotIncludeFile()`
`68`	`80`	`$this->assertArrayNotHasKey('x-body-file', $headers);`
`69`	`81`	`}`
`70`	`82`
	`83`	`+ /**`
	`84`	`+ * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.`
	`85`	`+ */`
`71`	`86`	`public function testDoesNotReadFile()`
`72`	`87`	`{`
`73`	`88`	`$file = __DIR__.'/Fixtures/assertion_failure.php';`
`@@ -83,6 +98,9 @@ public function testDoesNotReadFile()`
`83`	`98`	`$this->assertArrayNotHasKey('x-body-file', $headers);`
`84`	`99`	`}`
`85`	`100`
	`101`	`+ /**`
	`102`	`+ * @expectedDeprecation Since symfony/http-client 7.3: Passing a "Symfony\Component\HttpKernel\HttpCache\StoreInterface" as constructor's 2nd argument of "Symfony\Component\HttpClient\CachingHttpClient" is deprecated, "Symfony\Component\Cache\Adapter\TagAwareAdapterInterface" expected.`
	`103`	`+ */`
`86`	`104`	`public function testRemovesXContentDigest()`
`87`	`105`	`{`
`88`	`106`	`$response = $this->runRequest(new MockResponse(`