minor #23435 [TwigBridge] cleaner implementation of the TwigRenderer (Tobion)

nicolas-grekas · nicolas-grekas · commit 62fdf9c72bcb · 2017-07-13T15:48:31.000+02:00
This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] cleaner implementation of the TwigRenderer | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no  | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | #23432 (comment) | License | MIT | Doc PR |  Commits ------- c7c5ba8 [TwigBridge] cleaner implementation of the TwigRenderer
diff --git a/src/Symfony/Bridge/Twig/Form/TwigRenderer.php b/src/Symfony/Bridge/Twig/Form/TwigRenderer.php
@@ -19,23 +19,26 @@
  */
 class TwigRenderer extends FormRenderer implements TwigRendererInterface
 {
-    /**
-     * @var TwigRendererEngineInterface
-     */
-    private $engine;
-
     public function __construct(TwigRendererEngineInterface $engine, $csrfTokenManager = null)
     {
         parent::__construct($engine, $csrfTokenManager);
+    }
 
-        $this->engine = $engine;
+    /**
+     * Returns the engine used by this renderer.
+     *
+     * @return TwigRendererEngineInterface The renderer engine
+     */
+    public function getEngine()
+    {
+        return parent::getEngine();
     }
 
     /**
      * {@inheritdoc}
      */
     public function setEnvironment(Environment $environment)
     {
-        $this->engine->setEnvironment($environment);
+        $this->getEngine()->setEnvironment($environment);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,23 +19,26 @@`
`19`	`19`	`*/`
`20`	`20`	`class TwigRenderer extends FormRenderer implements TwigRendererInterface`
`21`	`21`	`{`
`22`		`- /**`
`23`		`- * @var TwigRendererEngineInterface`
`24`		`- */`
`25`		`- private $engine;`
`26`		`-`
`27`	`22`	`public function __construct(TwigRendererEngineInterface $engine, $csrfTokenManager = null)`
`28`	`23`	`{`
`29`	`24`	`parent::__construct($engine, $csrfTokenManager);`
	`25`	`+ }`
`30`	`26`
`31`		`- $this->engine = $engine;`
	`27`	`+ /**`
	`28`	`+ * Returns the engine used by this renderer.`
	`29`	`+ *`
	`30`	`+ * @return TwigRendererEngineInterface The renderer engine`
	`31`	`+ */`
	`32`	`+ public function getEngine()`
	`33`	`+ {`
	`34`	`+ return parent::getEngine();`
`32`	`35`	`}`
`33`	`36`
`34`	`37`	`/**`
`35`	`38`	`* {@inheritdoc}`
`36`	`39`	`*/`
`37`	`40`	`public function setEnvironment(Environment $environment)`
`38`	`41`	`{`
`39`		`- $this->engine->setEnvironment($environment);`
	`42`	`+ $this->getEngine()->setEnvironment($environment);`
`40`	`43`	`}`
`41`	`44`	`}`