bug #36716 [Mime] handle passing custom mime types as string (mcneely)

fabpot · fabpot · commit 6310084f2592 · 2020-05-09T14:32:08.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] handle passing custom mime types as string | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36715 | License | MIT | Doc PR | none Fix's issue where custom mimetypes were failing Commits ------- f3005ec Fix for #36715
diff --git a/src/Symfony/Component/Mime/MimeTypes.php b/src/Symfony/Component/Mime/MimeTypes.php
@@ -51,7 +51,7 @@ public function __construct(array $map = [])
             $this->extensions[$mimeType] = $extensions;
 
             foreach ($extensions as $extension) {
-                $this->mimeTypes[$extension] = $mimeType;
+                $this->mimeTypes[$extension][] = $mimeType;
             }
         }
         $this->registerGuesser(new FileBinaryMimeTypeGuesser());
diff --git a/src/Symfony/Component/Mime/Tests/MimeTypesTest.php b/src/Symfony/Component/Mime/Tests/MimeTypesTest.php
@@ -62,4 +62,15 @@ public function testGetMimeTypes()
         $this->assertContains('image/svg', $mt->getMimeTypes('svg'));
         $this->assertSame([], $mt->getMimeTypes('symfony'));
     }
+
+    public function testCustomMimeTypes()
+    {
+        $mt = new MimeTypes([
+            'text/bar' => ['foo'],
+            'text/baz' => ['foo', 'moof'],
+        ]);
+        $this->assertContains('text/bar', $mt->getMimeTypes('foo'));
+        $this->assertContains('text/baz', $mt->getMimeTypes('foo'));
+        $this->assertSame(['foo', 'moof'], $mt->getExtensions('text/baz'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function __construct(array $map = [])`
`51`	`51`	`$this->extensions[$mimeType] = $extensions;`
`52`	`52`
`53`	`53`	`foreach ($extensions as $extension) {`
`54`		`- $this->mimeTypes[$extension] = $mimeType;`
	`54`	`+ $this->mimeTypes[$extension][] = $mimeType;`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`	`$this->registerGuesser(new FileBinaryMimeTypeGuesser());`