[FrameworkBundle] Deprecate container parameters router.request_context.scheme and .host

stollr · nicolas-grekas · commit 66036ed4b1e0 · 2025-08-22T11:30:48.000+02:00
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -43,6 +43,8 @@ FrameworkBundle
 ---------------
 
  * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `addCommand()`
+ * Deprecate parameters `router.request_context.scheme` and `router.request_context.host`;
+   use `router.request_context.base_url` or the `framework.router.default_uri` config option instead
 
 HtmlSanitizer
 -------------
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -9,6 +9,8 @@ CHANGELOG
  * Deprecate `Symfony\Bundle\FrameworkBundle\Console\Application::add()` in favor of `Symfony\Bundle\FrameworkBundle\Console\Application::addCommand()`
  * Add `assertEmailAddressNotContains()` to the `MailerAssertionsTrait`
  * Add `framework.type_info.aliases` option
+ * Deprecate parameters `router.request_context.scheme` and `router.request_context.host`;
+   use `router.request_context.base_url` or the `framework.router.default_uri` config option instead
 
 7.3
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1307,6 +1307,9 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co
 
         $loader->load('routing.php');
 
+        $container->deprecateParameter('router.request_context.scheme', 'symfony/framework-bundle', '7.4', 'Parameter "router.request_context.scheme" is deprecated, use "router.request_context.base_url" or the "framework.router.default_uri" config option instead.');
+        $container->deprecateParameter('router.request_context.host', 'symfony/framework-bundle', '7.4', 'Parameter "router.request_context.host" is deprecated, use "router.request_context.base_url" or the "framework.router.default_uri" config option instead.');
+
         if ($config['utf8']) {
             $container->getDefinition('routing.loader')->replaceArgument(1, ['utf8' => true]);
         }
@@ -1334,8 +1337,7 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co
         $container->setParameter('request_listener.https_port', $config['https_port']);
 
         if (null !== $config['default_uri']) {
-            $container->getDefinition('router.request_context')
-                ->replaceArgument(0, $config['default_uri']);
+            $container->setParameter('router.request_context.base_url', $config['default_uri']);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1307,6 +1307,9 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co`
`1307`	`1307`
`1308`	`1308`	`$loader->load('routing.php');`
`1309`	`1309`
	`1310`	`+ $container->deprecateParameter('router.request_context.scheme', 'symfony/framework-bundle', '7.4', 'Parameter "router.request_context.scheme" is deprecated, use "router.request_context.base_url" or the "framework.router.default_uri" config option instead.');`
	`1311`	`+ $container->deprecateParameter('router.request_context.host', 'symfony/framework-bundle', '7.4', 'Parameter "router.request_context.host" is deprecated, use "router.request_context.base_url" or the "framework.router.default_uri" config option instead.');`
	`1312`	`+`
`1310`	`1313`	`if ($config['utf8']) {`
`1311`	`1314`	`$container->getDefinition('routing.loader')->replaceArgument(1, ['utf8' => true]);`
`1312`	`1315`	`}`
`@@ -1334,8 +1337,7 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co`
`1334`	`1337`	`$container->setParameter('request_listener.https_port', $config['https_port']);`
`1335`	`1338`
`1336`	`1339`	`if (null !== $config['default_uri']) {`
`1337`		`- $container->getDefinition('router.request_context')`
`1338`		`- ->replaceArgument(0, $config['default_uri']);`
	`1340`	`+ $container->setParameter('router.request_context.base_url', $config['default_uri']);`
`1339`	`1341`	`}`
`1340`	`1342`	`}`
`1341`	`1343`