Log a more readable message when trying to cache an unsupported type

Jérôme Deuchnord · Jérôme Deuchnord · commit 727734000e6f · 2019-05-06T16:01:47.000+02:00
diff --git a/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php b/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php
@@ -164,7 +164,12 @@ public function commit()
                     $ok = false;
                     $v = $values[$id];
                     $type = \is_object($v) ? \get_class($v) : \gettype($v);
-                    CacheItem::log($this->logger, 'Failed to save key "{key}" ({type})', ['key' => substr($id, \strlen($this->namespace)), 'type' => $type, 'exception' => $e instanceof \Exception ? $e : null]);
+                    $this->logger->warning(\sprintf(
+                        'Could not save key "%s" in cache: the %s type is not supported.',
+                        $id,
+                        $type
+                    ));
+                    $this->logger->warning('Tip: check that the type you are trying to save is cacheable: https://symfony.com/doc/current/components/cache.html#available-cache-adapters, or create your own adapter.');
                 }
             } else {
                 foreach ($values as $id => $v) {
