CS Fixes: lowercase null constants

keradus · keradus · commit 72d37221d15f · 2014-12-07T03:29:25.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -1072,6 +1072,11 @@ private function exportParameters($parameters, $path = '', $indent = 12)
                 throw new InvalidArgumentException(sprintf('You cannot dump a container with parameters that contain expressions. Expression "%s" found in "%s".', $value, $path.'/'.$key));
             } else {
                 $value = $this->export($value);
+
+                // If exported value is `null` then standardize it: `true` and `false` are exported in lower-case, so let do the same with `null`.
+                if ('NULL' === $value) {
+                    $value = 'null';
+                }
             }
 
             $php[] = sprintf('%s%s => %s,', str_repeat(' ', $indent), var_export($key, true), $value);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services8.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services8.php
@@ -31,7 +31,7 @@ public function __construct()
             'values' => array(
                 0 => true,
                 1 => false,
-                2 => NULL,
+                2 => null,
                 3 => 0,
                 4 => 1000.3,
                 5 => 'true',
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services9_compiled.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services9_compiled.php
@@ -268,8 +268,8 @@ protected function getMethodCall1Service()
         $this->services['method_call1'] = $instance = new \Bar\FooClass();
 
         $instance->setBar($this->get('foo'));
-        $instance->setBar(NULL);
-        $instance->setBar(($this->get("foo")->foo() . (($this->hasparameter("foo")) ? ($this->getParameter("foo")) : ("default"))));
+        $instance->setBar(null);
+        $instance->setBar(($this->get("foo")->foo().(($this->hasparameter("foo")) ? ($this->getParameter("foo")) : ("default"))));
 
         return $instance;
     }

Original file line number	Diff line number	Diff line change
`@@ -268,8 +268,8 @@ protected function getMethodCall1Service()`
`268`	`268`	`$this->services['method_call1'] = $instance = new \Bar\FooClass();`
`269`	`269`
`270`	`270`	`$instance->setBar($this->get('foo'));`
`271`		`- $instance->setBar(NULL);`
`272`		`- $instance->setBar(($this->get("foo")->foo() . (($this->hasparameter("foo")) ? ($this->getParameter("foo")) : ("default"))));`
	`271`	`+ $instance->setBar(null);`
	`272`	`+ $instance->setBar(($this->get("foo")->foo().(($this->hasparameter("foo")) ? ($this->getParameter("foo")) : ("default"))));`
`273`	`273`
`274`	`274`	`return $instance;`
`275`	`275`	`}`