bug #23539 [Stopwatch] Fix precision for root section (gharlan)

nicolas-grekas · nicolas-grekas · commit 73c11a7986ac · 2017-07-17T09:33:46.000+02:00
This PR was squashed before being merged into the 3.4 branch (closes #23539). Discussion ---------- [Stopwatch] Fix precision for root section | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- b2c0dc3 [Stopwatch] Fix precision for root section
diff --git a/src/Symfony/Component/Stopwatch/Stopwatch.php b/src/Symfony/Component/Stopwatch/Stopwatch.php
@@ -38,8 +38,8 @@ class Stopwatch
      */
     public function __construct($morePrecision = false)
     {
-        $this->reset();
         $this->morePrecision = $morePrecision;
+        $this->reset();
     }
 
     /**
diff --git a/src/Symfony/Component/Stopwatch/Tests/StopwatchTest.php b/src/Symfony/Component/Stopwatch/Tests/StopwatchTest.php
@@ -100,6 +100,18 @@ public function testStopWithoutStart()
         $stopwatch->stop('foo');
     }
 
+    public function testMorePrecision()
+    {
+        $stopwatch = new Stopwatch(true);
+
+        $stopwatch->start('foo');
+        $event = $stopwatch->stop('foo');
+
+        $this->assertInternalType('float', $event->getStartTime());
+        $this->assertInternalType('float', $event->getEndTime());
+        $this->assertInternalType('float', $event->getDuration());
+    }
+
     public function testSection()
     {
         $stopwatch = new Stopwatch();

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,8 @@ class Stopwatch`
`38`	`38`	`*/`
`39`	`39`	`public function __construct($morePrecision = false)`
`40`	`40`	`{`
`41`		`- $this->reset();`
`42`	`41`	`$this->morePrecision = $morePrecision;`
	`42`	`+ $this->reset();`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/**`