Merge branch '5.4' into 6.4

xabbuh · xabbuh · commit 783e624bf949 · 2024-10-01T10:30:56.000+02:00
* 5.4:
  do not base services on PHPUnit mocks
  do not use TestCase::getName() when possible
  do not use assertCount() with generators
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php b/src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php
@@ -23,8 +23,11 @@
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\HttpKernel\DataCollector\DumpDataCollector;
 use Symfony\Component\HttpKernel\KernelInterface;
+use Symfony\Component\HttpKernel\Profiler\Profile;
 use Symfony\Component\HttpKernel\Profiler\Profiler;
 use Symfony\Component\HttpKernel\Profiler\ProfilerStorageInterface;
+use Symfony\Component\Routing\RequestContext;
+use Symfony\Component\Routing\RouteCollection;
 use Symfony\Component\Routing\RouterInterface;
 use Twig\Environment;
 use Twig\Loader\ArrayLoader;
@@ -58,15 +61,11 @@ protected function setUp(): void
 
         $this->kernel = $this->createMock(KernelInterface::class);
 
-        $profiler = $this->createMock(Profiler::class);
-        $profilerStorage = $this->createMock(ProfilerStorageInterface::class);
-        $router = $this->createMock(RouterInterface::class);
-
         $this->container = new ContainerBuilder();
         $this->container->register('data_collector.dump', DumpDataCollector::class)->setPublic(true);
         $this->container->register('error_handler.error_renderer.html', HtmlErrorRenderer::class)->setPublic(true);
         $this->container->register('event_dispatcher', EventDispatcher::class)->setPublic(true);
-        $this->container->register('router', $router::class)->setPublic(true);
+        $this->container->register('router', Router::class)->setPublic(true);
         $this->container->register('twig', Environment::class)->setPublic(true);
         $this->container->register('twig_loader', ArrayLoader::class)->addArgument([])->setPublic(true);
         $this->container->register('twig', Environment::class)->addArgument(new Reference('twig_loader'))->setPublic(true);
@@ -78,9 +77,9 @@ protected function setUp(): void
         $this->container->setParameter('kernel.charset', 'UTF-8');
         $this->container->setParameter('debug.file_link_format', null);
         $this->container->setParameter('profiler.class', [Profiler::class]);
-        $this->container->register('profiler', $profiler::class)
+        $this->container->register('profiler', Profiler::class)
             ->setPublic(true)
-            ->addArgument(new Definition($profilerStorage::class));
+            ->addArgument(new Definition(NullProfilerStorage::class));
         $this->container->setParameter('data_collector.templates', []);
         $this->container->set('kernel', $this->kernel);
         $this->container->addCompilerPass(new RegisterListenersPass());
@@ -211,3 +210,54 @@ private function getCompiledContainer()
         return $this->container;
     }
 }
+
+class Router implements RouterInterface
+{
+    private $context;
+
+    public function setContext(RequestContext $context): void
+    {
+        $this->context = $context;
+    }
+
+    public function getContext(): RequestContext
+    {
+        return $this->context;
+    }
+
+    public function getRouteCollection(): RouteCollection
+    {
+        return new RouteCollection();
+    }
+
+    public function generate(string $name, array $parameters = [], int $referenceType = self::ABSOLUTE_PATH): string
+    {
+    }
+
+    public function match(string $pathinfo): array
+    {
+        return [];
+    }
+}
+
+class NullProfilerStorage implements ProfilerStorageInterface
+{
+    public function find(?string $ip, ?string $url, ?int $limit, ?string $method, ?int $start = null, ?int $end = null): array
+    {
+        return [];
+    }
+
+    public function read(string $token): ?Profile
+    {
+        return null;
+    }
+
+    public function write(Profile $profile): bool
+    {
+        return true;
+    }
+
+    public function purge()
+    {
+    }
+}
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/ApcuAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/ApcuAdapterTest.php
@@ -30,7 +30,7 @@ public function createCachePool(int $defaultLifetime = 0): CacheItemPoolInterfac
             $this->markTestSkipped('APCu extension is required.');
         }
         if ('cli' === \PHP_SAPI && !filter_var(\ini_get('apc.enable_cli'), \FILTER_VALIDATE_BOOL)) {
-            if ('testWithCliSapi' !== $this->getName()) {
+            if ('testWithCliSapi' !== (method_exists($this, 'name') ? $this->name() : $this->getName())) {
                 $this->markTestSkipped('apc.enable_cli=1 is required.');
             }
         }
diff --git a/src/Symfony/Component/Finder/Tests/Iterator/LazyIteratorTest.php b/src/Symfony/Component/Finder/Tests/Iterator/LazyIteratorTest.php
@@ -29,7 +29,7 @@ public function testDelegate()
     {
         $iterator = new LazyIterator(fn () => new Iterator(['foo', 'bar']));
 
-        $this->assertCount(2, $iterator);
+        $this->assertCount(2, iterator_to_array($iterator));
     }
 
     public function testInnerDestructedAtTheEnd()
diff --git a/src/Symfony/Component/Routing/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php b/src/Symfony/Component/Routing/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php
@@ -37,8 +37,8 @@ protected function setUp(): void
 
         $this->routeCollection = new RouteCollection();
         $this->generatorDumper = new CompiledUrlGeneratorDumper($this->routeCollection);
-        $this->testTmpFilepath = sys_get_temp_dir().'/php_generator.'.$this->getName().'.php';
-        $this->largeTestTmpFilepath = sys_get_temp_dir().'/php_generator.'.$this->getName().'.large.php';
+        $this->testTmpFilepath = sys_get_temp_dir().'/php_generator.php';
+        $this->largeTestTmpFilepath = sys_get_temp_dir().'/php_generator.large.php';
         @unlink($this->testTmpFilepath);
         @unlink($this->largeTestTmpFilepath);
     }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function createCachePool(int $defaultLifetime = 0): CacheItemPoolInterfac`
`30`	`30`	`$this->markTestSkipped('APCu extension is required.');`
`31`	`31`	`}`
`32`	`32`	`if ('cli' === \PHP_SAPI && !filter_var(\ini_get('apc.enable_cli'), \FILTER_VALIDATE_BOOL)) {`
`33`		`- if ('testWithCliSapi' !== $this->getName()) {`
	`33`	`+ if ('testWithCliSapi' !== (method_exists($this, 'name') ? $this->name() : $this->getName())) {`
`34`	`34`	`$this->markTestSkipped('apc.enable_cli=1 is required.');`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function testDelegate()`
`29`	`29`	`{`
`30`	`30`	`$iterator = new LazyIterator(fn () => new Iterator(['foo', 'bar']));`
`31`	`31`
`32`		`- $this->assertCount(2, $iterator);`
	`32`	`+ $this->assertCount(2, iterator_to_array($iterator));`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`public function testInnerDestructedAtTheEnd()`