Remove void return type from test methods

OskarStark · OskarStark · commit 78da70615b1a · 2020-12-18T07:28:27.000+01:00
diff --git a/src/Symfony/Component/Mailer/Tests/Transport/DsnTest.php b/src/Symfony/Component/Mailer/Tests/Transport/DsnTest.php
@@ -20,12 +20,12 @@ class DsnTest extends TestCase
     /**
      * @dataProvider fromStringProvider
      */
-    public function testFromString(string $string, Dsn $dsn): void
+    public function testFromString(string $string, Dsn $dsn)
     {
         $this->assertEquals($dsn, Dsn::fromString($string));
     }
 
-    public function testGetOption(): void
+    public function testGetOption()
     {
         $options = ['with_value' => 'some value', 'nullable' => null];
         $dsn = new Dsn('smtp', 'example.com', null, null, null, $options);
@@ -38,7 +38,7 @@ public function testGetOption(): void
     /**
      * @dataProvider invalidDsnProvider
      */
-    public function testInvalidDsn(string $dsn, string $exceptionMessage): void
+    public function testInvalidDsn(string $dsn, string $exceptionMessage)
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage($exceptionMessage);
diff --git a/src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/AmazonSqsIntegrationTest.php b/src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/AmazonSqsIntegrationTest.php
@@ -21,7 +21,7 @@
  */
 class AmazonSqsIntegrationTest extends TestCase
 {
-    public function testConnectionSendToFifoQueueAndGet(): void
+    public function testConnectionSendToFifoQueueAndGet()
     {
         if (!getenv('MESSENGER_SQS_FIFO_QUEUE_DSN')) {
             $this->markTestSkipped('The "MESSENGER_SQS_FIFO_QUEUE_DSN" environment variable is required.');
@@ -30,7 +30,7 @@ public function testConnectionSendToFifoQueueAndGet(): void
         $this->execute(getenv('MESSENGER_SQS_FIFO_QUEUE_DSN'));
     }
 
-    public function testConnectionSendAndGet(): void
+    public function testConnectionSendAndGet()
     {
         if (!getenv('MESSENGER_SQS_DSN')) {
             $this->markTestSkipped('The "MESSENGER_SQS_DSN" environment variable is required.');
diff --git a/src/Symfony/Component/Messenger/Tests/EventListener/StopWorkerOnFailureLimitListenerTest.php b/src/Symfony/Component/Messenger/Tests/EventListener/StopWorkerOnFailureLimitListenerTest.php
@@ -26,7 +26,7 @@ class StopWorkerOnFailureLimitListenerTest extends TestCase
     /**
      * @dataProvider countProvider
      */
-    public function testWorkerStopsWhenMaximumCountReached(int $max, bool $shouldStop): void
+    public function testWorkerStopsWhenMaximumCountReached(int $max, bool $shouldStop)
     {
         $worker = $this->createMock(Worker::class);
         $worker->expects($shouldStop ? $this->atLeastOnce() : $this->never())->method('stop');
@@ -53,7 +53,7 @@ public function countProvider(): iterable
         yield [4, false];
     }
 
-    public function testWorkerLogsMaximumCountReachedWhenLoggerIsGiven(): void
+    public function testWorkerLogsMaximumCountReachedWhenLoggerIsGiven()
     {
         $logger = $this->createMock(LoggerInterface::class);
         $logger->expects($this->once())->method('info')
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/ExpressionLanguageSyntaxValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/ExpressionLanguageSyntaxValidatorTest.php
@@ -23,7 +23,7 @@ protected function createValidator()
         return new ExpressionLanguageSyntaxValidator(new ExpressionLanguage());
     }
 
-    public function testExpressionValid(): void
+    public function testExpressionValid()
     {
         $this->validator->validate('1 + 1', new ExpressionLanguageSyntax([
             'message' => 'myMessage',
@@ -33,7 +33,7 @@ public function testExpressionValid(): void
         $this->assertNoViolation();
     }
 
-    public function testExpressionWithoutNames(): void
+    public function testExpressionWithoutNames()
     {
         $this->validator->validate('1 + 1', new ExpressionLanguageSyntax([
             'message' => 'myMessage',
@@ -42,7 +42,7 @@ public function testExpressionWithoutNames(): void
         $this->assertNoViolation();
     }
 
-    public function testExpressionWithAllowedVariableName(): void
+    public function testExpressionWithAllowedVariableName()
     {
         $this->validator->validate('a + 1', new ExpressionLanguageSyntax([
             'message' => 'myMessage',
@@ -52,7 +52,7 @@ public function testExpressionWithAllowedVariableName(): void
         $this->assertNoViolation();
     }
 
-    public function testExpressionIsNotValid(): void
+    public function testExpressionIsNotValid()
     {
         $this->validator->validate('a + 1', new ExpressionLanguageSyntax([
             'message' => 'myMessage',

Original file line number	Diff line number	Diff line change
`@@ -20,12 +20,12 @@ class DsnTest extends TestCase`
`20`	`20`	`/**`
`21`	`21`	`* @dataProvider fromStringProvider`
`22`	`22`	`*/`
`23`		`- public function testFromString(string $string, Dsn $dsn): void`
	`23`	`+ public function testFromString(string $string, Dsn $dsn)`
`24`	`24`	`{`
`25`	`25`	`$this->assertEquals($dsn, Dsn::fromString($string));`
`26`	`26`	`}`
`27`	`27`
`28`		`- public function testGetOption(): void`
	`28`	`+ public function testGetOption()`
`29`	`29`	`{`
`30`	`30`	`$options = ['with_value' => 'some value', 'nullable' => null];`
`31`	`31`	`$dsn = new Dsn('smtp', 'example.com', null, null, null, $options);`
`@@ -38,7 +38,7 @@ public function testGetOption(): void`
`38`	`38`	`/**`
`39`	`39`	`* @dataProvider invalidDsnProvider`
`40`	`40`	`*/`
`41`		`- public function testInvalidDsn(string $dsn, string $exceptionMessage): void`
	`41`	`+ public function testInvalidDsn(string $dsn, string $exceptionMessage)`
`42`	`42`	`{`
`43`	`43`	`$this->expectException(InvalidArgumentException::class);`
`44`	`44`	`$this->expectExceptionMessage($exceptionMessage);`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`*/`
`22`	`22`	`class AmazonSqsIntegrationTest extends TestCase`
`23`	`23`	`{`
`24`		`- public function testConnectionSendToFifoQueueAndGet(): void`
	`24`	`+ public function testConnectionSendToFifoQueueAndGet()`
`25`	`25`	`{`
`26`	`26`	`if (!getenv('MESSENGER_SQS_FIFO_QUEUE_DSN')) {`
`27`	`27`	`$this->markTestSkipped('The "MESSENGER_SQS_FIFO_QUEUE_DSN" environment variable is required.');`
`@@ -30,7 +30,7 @@ public function testConnectionSendToFifoQueueAndGet(): void`
`30`	`30`	`$this->execute(getenv('MESSENGER_SQS_FIFO_QUEUE_DSN'));`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function testConnectionSendAndGet(): void`
	`33`	`+ public function testConnectionSendAndGet()`
`34`	`34`	`{`
`35`	`35`	`if (!getenv('MESSENGER_SQS_DSN')) {`
`36`	`36`	`$this->markTestSkipped('The "MESSENGER_SQS_DSN" environment variable is required.');`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class StopWorkerOnFailureLimitListenerTest extends TestCase`
`26`	`26`	`/**`
`27`	`27`	`* @dataProvider countProvider`
`28`	`28`	`*/`
`29`		`- public function testWorkerStopsWhenMaximumCountReached(int $max, bool $shouldStop): void`
	`29`	`+ public function testWorkerStopsWhenMaximumCountReached(int $max, bool $shouldStop)`
`30`	`30`	`{`
`31`	`31`	`$worker = $this->createMock(Worker::class);`
`32`	`32`	`$worker->expects($shouldStop ? $this->atLeastOnce() : $this->never())->method('stop');`
`@@ -53,7 +53,7 @@ public function countProvider(): iterable`
`53`	`53`	`yield [4, false];`
`54`	`54`	`}`
`55`	`55`
`56`		`- public function testWorkerLogsMaximumCountReachedWhenLoggerIsGiven(): void`
	`56`	`+ public function testWorkerLogsMaximumCountReachedWhenLoggerIsGiven()`
`57`	`57`	`{`
`58`	`58`	`$logger = $this->createMock(LoggerInterface::class);`
`59`	`59`	`$logger->expects($this->once())->method('info')`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ protected function createValidator()`
`23`	`23`	`return new ExpressionLanguageSyntaxValidator(new ExpressionLanguage());`
`24`	`24`	`}`
`25`	`25`
`26`		`- public function testExpressionValid(): void`
	`26`	`+ public function testExpressionValid()`
`27`	`27`	`{`
`28`	`28`	`$this->validator->validate('1 + 1', new ExpressionLanguageSyntax([`
`29`	`29`	`'message' => 'myMessage',`
`@@ -33,7 +33,7 @@ public function testExpressionValid(): void`
`33`	`33`	`$this->assertNoViolation();`
`34`	`34`	`}`
`35`	`35`
`36`		`- public function testExpressionWithoutNames(): void`
	`36`	`+ public function testExpressionWithoutNames()`
`37`	`37`	`{`
`38`	`38`	`$this->validator->validate('1 + 1', new ExpressionLanguageSyntax([`
`39`	`39`	`'message' => 'myMessage',`
`@@ -42,7 +42,7 @@ public function testExpressionWithoutNames(): void`
`42`	`42`	`$this->assertNoViolation();`
`43`	`43`	`}`
`44`	`44`
`45`		`- public function testExpressionWithAllowedVariableName(): void`
	`45`	`+ public function testExpressionWithAllowedVariableName()`
`46`	`46`	`{`
`47`	`47`	`$this->validator->validate('a + 1', new ExpressionLanguageSyntax([`
`48`	`48`	`'message' => 'myMessage',`
`@@ -52,7 +52,7 @@ public function testExpressionWithAllowedVariableName(): void`
`52`	`52`	`$this->assertNoViolation();`
`53`	`53`	`}`
`54`	`54`
`55`		`- public function testExpressionIsNotValid(): void`
	`55`	`+ public function testExpressionIsNotValid()`
`56`	`56`	`{`
`57`	`57`	`$this->validator->validate('a + 1', new ExpressionLanguageSyntax([`
`58`	`58`	`'message' => 'myMessage',`