add ResetInterface

Jean-Beru · Jean-Beru · commit 802cd2c0a699 · 2025-05-05T10:56:16.000+02:00
diff --git a/src/Symfony/Component/FeatureFlag/FeatureChecker.php b/src/Symfony/Component/FeatureFlag/FeatureChecker.php
@@ -12,11 +12,12 @@
 namespace Symfony\Component\FeatureFlag;
 
 use Symfony\Component\FeatureFlag\Provider\ProviderInterface;
+use Symfony\Contracts\Service\ResetInterface;
 
 /**
  * @experimental
  */
-final class FeatureChecker implements FeatureCheckerInterface
+final class FeatureChecker implements FeatureCheckerInterface, ResetInterface
 {
     private array $cache = [];
 
@@ -40,4 +41,9 @@ public function getValue(string $featureName): mixed
 
         return $this->cache[$featureName] = $feature();
     }
+
+    public function reset(): void
+    {
+        $this->cache = [];
+    }
 }
diff --git a/src/Symfony/Component/FeatureFlag/Tests/FeatureCheckerTest.php b/src/Symfony/Component/FeatureFlag/Tests/FeatureCheckerTest.php
@@ -18,6 +18,7 @@
 class FeatureCheckerTest extends TestCase
 {
     private FeatureChecker $featureChecker;
+    private int $counter = 0;
 
     protected function setUp(): void
     {
@@ -26,6 +27,7 @@ protected function setUp(): void
             'feature_false' => fn () => false,
             'feature_integer' => fn () => 42,
             'feature_random' => fn () => random_int(1, 42),
+            'feature_counter' => fn () => ++$this->counter,
         ]));
     }
 
@@ -60,4 +62,14 @@ public static function provideIsEnabled(): iterable
         yield 'an integer' => ['feature_integer', false];
         yield 'an unknown feature' => ['unknown_feature', false];
     }
+
+    public function testReset()
+    {
+        $this->assertSame(1, $this->featureChecker->getValue('feature_counter'));
+        $this->assertSame(1, $this->featureChecker->getValue('feature_counter'));
+
+        $this->featureChecker->reset();
+
+        $this->assertSame(2, $this->featureChecker->getValue('feature_counter'));
+    }
 }
diff --git a/src/Symfony/Component/FeatureFlag/composer.json b/src/Symfony/Component/FeatureFlag/composer.json
@@ -17,7 +17,8 @@
     ],
     "require": {
         "php": ">=8.2",
-        "psr/container": "^1.1|^2.0"
+        "psr/container": "^1.1|^2.0",
+        "symfony/service-contracts": "^2.5|^3"
     },
     "require-dev": {
         "symfony/http-kernel": "^7.2",

Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,12 @@`
`12`	`12`	`namespace Symfony\Component\FeatureFlag;`
`13`	`13`
`14`	`14`	`use Symfony\Component\FeatureFlag\Provider\ProviderInterface;`
	`15`	`+use Symfony\Contracts\Service\ResetInterface;`
`15`	`16`
`16`	`17`	`/**`
`17`	`18`	`* @experimental`
`18`	`19`	`*/`
`19`		`-final class FeatureChecker implements FeatureCheckerInterface`
	`20`	`+final class FeatureChecker implements FeatureCheckerInterface, ResetInterface`
`20`	`21`	`{`
`21`	`22`	`private array $cache = [];`
`22`	`23`
`@@ -40,4 +41,9 @@ public function getValue(string $featureName): mixed`
`40`	`41`
`41`	`42`	`return $this->cache[$featureName] = $feature();`
`42`	`43`	`}`
	`44`	`+`
	`45`	`+ public function reset(): void`
	`46`	`+ {`
	`47`	`+ $this->cache = [];`
	`48`	`+ }`
`43`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`class FeatureCheckerTest extends TestCase`
`19`	`19`	`{`
`20`	`20`	`private FeatureChecker $featureChecker;`
	`21`	`+ private int $counter = 0;`
`21`	`22`
`22`	`23`	`protected function setUp(): void`
`23`	`24`	`{`
`@@ -26,6 +27,7 @@ protected function setUp(): void`
`26`	`27`	`'feature_false' => fn () => false,`
`27`	`28`	`'feature_integer' => fn () => 42,`
`28`	`29`	`'feature_random' => fn () => random_int(1, 42),`
	`30`	`+ 'feature_counter' => fn () => ++$this->counter,`
`29`	`31`	`]));`
`30`	`32`	`}`
`31`	`33`
`@@ -60,4 +62,14 @@ public static function provideIsEnabled(): iterable`
`60`	`62`	`yield 'an integer' => ['feature_integer', false];`
`61`	`63`	`yield 'an unknown feature' => ['unknown_feature', false];`
`62`	`64`	`}`
	`65`	`+`
	`66`	`+ public function testReset()`
	`67`	`+ {`
	`68`	`+ $this->assertSame(1, $this->featureChecker->getValue('feature_counter'));`
	`69`	`+ $this->assertSame(1, $this->featureChecker->getValue('feature_counter'));`
	`70`	`+`
	`71`	`+ $this->featureChecker->reset();`
	`72`	`+`
	`73`	`+ $this->assertSame(2, $this->featureChecker->getValue('feature_counter'));`
	`74`	`+ }`
`63`	`75`	`}`