minor #59125 [Scheduler] Fix optional $count variable in testGetNextRunDates (codedmonkey)

fabpot · fabpot · commit 80b0826e7b66 · 2024-12-14T17:55:46.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Scheduler] Fix optional `$count` variable in `testGetNextRunDates` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes (in tests) | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Fixes a weird side effect of the optional `$count` variable in `testGetNextRunDates`, because it uses the Null Coalescing Operator it was always expecting 0 iterations if not passing a value from the provider. It doesn't need to be optional because it's always passed from the provider so we could just make it a required variable. Commits ------- d8fa076 [Scheduler] Fix optional count variable in testGetNextRunDates
diff --git a/src/Symfony/Component/Scheduler/Tests/Trigger/PeriodicalTriggerTest.php b/src/Symfony/Component/Scheduler/Tests/Trigger/PeriodicalTriggerTest.php
@@ -108,9 +108,9 @@ public static function provideForToString()
     /**
      * @dataProvider providerGetNextRunDates
      */
-    public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, int $count = 0)
+    public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, int $count)
     {
-        $this->assertEquals($expected, $this->getNextRunDates($from, $trigger, $count ?? \count($expected)));
+        $this->assertEquals($expected, $this->getNextRunDates($from, $trigger, $count));
     }
 
     public static function providerGetNextRunDates(): iterable

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,9 @@ public static function provideForToString()`
`108`	`108`	`/**`
`109`	`109`	`* @dataProvider providerGetNextRunDates`
`110`	`110`	`*/`
`111`		`- public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, int $count = 0)`
	`111`	`+ public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, int $count)`
`112`	`112`	`{`
`113`		`- $this->assertEquals($expected, $this->getNextRunDates($from, $trigger, $count ?? \count($expected)));`
	`113`	`+ $this->assertEquals($expected, $this->getNextRunDates($from, $trigger, $count));`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`public static function providerGetNextRunDates(): iterable`