remove is_writable check on filesystem cache

4rthem · 4rthem · commit 834b50f03e66 · 2016-12-22T14:40:27.000+01:00
diff --git a/src/Symfony/Component/Cache/Adapter/FilesystemAdapter.php b/src/Symfony/Component/Cache/Adapter/FilesystemAdapter.php
@@ -34,14 +34,11 @@ public function __construct($namespace = '', $defaultLifetime = 0, $directory =
             $directory .= '/'.$namespace;
         }
         if (!file_exists($dir = $directory.'/.')) {
-            @mkdir($directory, 0777, true);
+            @mkdir($directory, 0755, true);
         }
         if (false === $dir = realpath($dir) ?: (file_exists($dir) ? $dir : false)) {
             throw new InvalidArgumentException(sprintf('Cache directory does not exist (%s)', $directory));
         }
-        if (!is_writable($dir .= DIRECTORY_SEPARATOR)) {
-            throw new InvalidArgumentException(sprintf('Cache directory is not writable (%s)', $directory));
-        }
         // On Windows the whole path is limited to 258 chars
         if ('\\' === DIRECTORY_SEPARATOR && strlen($dir) > 234) {
             throw new InvalidArgumentException(sprintf('Cache directory too long (%s)', $directory));
@@ -150,7 +147,7 @@ private function getFile($id, $mkdir = false)
         $dir = $this->directory.strtoupper($hash[0].DIRECTORY_SEPARATOR.$hash[1].DIRECTORY_SEPARATOR);
 
         if ($mkdir && !file_exists($dir)) {
-            @mkdir($dir, 0777, true);
+            @mkdir($dir, 0755, true);
         }
 
         return $dir.substr($hash, 2, 20);

Original file line number	Diff line number	Diff line change
`@@ -34,14 +34,11 @@ public function __construct($namespace = '', $defaultLifetime = 0, $directory =`
`34`	`34`	`$directory .= '/'.$namespace;`
`35`	`35`	`}`
`36`	`36`	`if (!file_exists($dir = $directory.'/.')) {`
`37`		`- @mkdir($directory, 0777, true);`
	`37`	`+ @mkdir($directory, 0755, true);`
`38`	`38`	`}`
`39`	`39`	`if (false === $dir = realpath($dir) ?: (file_exists($dir) ? $dir : false)) {`
`40`	`40`	`throw new InvalidArgumentException(sprintf('Cache directory does not exist (%s)', $directory));`
`41`	`41`	`}`
`42`		`- if (!is_writable($dir .= DIRECTORY_SEPARATOR)) {`
`43`		`- throw new InvalidArgumentException(sprintf('Cache directory is not writable (%s)', $directory));`
`44`		`- }`
`45`	`42`	`// On Windows the whole path is limited to 258 chars`
`46`	`43`	`if ('\\' === DIRECTORY_SEPARATOR && strlen($dir) > 234) {`
`47`	`44`	`throw new InvalidArgumentException(sprintf('Cache directory too long (%s)', $directory));`
`@@ -150,7 +147,7 @@ private function getFile($id, $mkdir = false)`
`150`	`147`	`$dir = $this->directory.strtoupper($hash[0].DIRECTORY_SEPARATOR.$hash[1].DIRECTORY_SEPARATOR);`
`151`	`148`
`152`	`149`	`if ($mkdir && !file_exists($dir)) {`
`153`		`- @mkdir($dir, 0777, true);`
	`150`	`+ @mkdir($dir, 0755, true);`
`154`	`151`	`}`
`155`	`152`
`156`	`153`	`return $dir.substr($hash, 2, 20);`