minor #54918 [PasswordHasher] fix tests (xabbuh)

xabbuh · xabbuh · commit 84f0b885ec4f · 2024-05-14T09:21:29.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [PasswordHasher] fix tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 82a9502 fix tests
diff --git a/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php b/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php
@@ -128,7 +128,7 @@ public function testBcryptWithNulByteWithNativePasswordHash()
             $this->markTestSkipped('password_hash() does not accept passwords containing NUL bytes.');
         }
 
-        $this->assertTrue($hasher->verify($hash, $plainPassword));
+        $this->assertFalse($hasher->verify($hash, $plainPassword));
     }
 
     public function testPasswordNulByteGracefullyHandled()
diff --git a/src/Symfony/Component/PasswordHasher/Tests/Hasher/SodiumPasswordHasherTest.php b/src/Symfony/Component/PasswordHasher/Tests/Hasher/SodiumPasswordHasherTest.php
@@ -103,7 +103,7 @@ public function testBcryptWithNulByteWithNativePasswordHash()
             $this->markTestSkipped('password_hash() does not accept passwords containing NUL bytes.');
         }
 
-        $this->assertTrue($hasher->verify($hash, $plainPassword));
+        $this->assertFalse($hasher->verify($hash, $plainPassword));
     }
 
     public function testPasswordNulByteGracefullyHandled()

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public function testBcryptWithNulByteWithNativePasswordHash()`
`128`	`128`	`$this->markTestSkipped('password_hash() does not accept passwords containing NUL bytes.');`
`129`	`129`	`}`
`130`	`130`
`131`		`- $this->assertTrue($hasher->verify($hash, $plainPassword));`
	`131`	`+ $this->assertFalse($hasher->verify($hash, $plainPassword));`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`public function testPasswordNulByteGracefullyHandled()`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function testBcryptWithNulByteWithNativePasswordHash()`
`103`	`103`	`$this->markTestSkipped('password_hash() does not accept passwords containing NUL bytes.');`
`104`	`104`	`}`
`105`	`105`
`106`		`- $this->assertTrue($hasher->verify($hash, $plainPassword));`
	`106`	`+ $this->assertFalse($hasher->verify($hash, $plainPassword));`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`public function testPasswordNulByteGracefullyHandled()`