change constructor argument type to expect a Key instance

xabbuh · xabbuh · commit 85a1c4e577da · 2025-05-22T13:57:40.000+02:00
This way we don't hide the fact that the DeduplicateStamp requires the Lock
component to be installed.
diff --git a/src/Symfony/Component/Messenger/Stamp/DeduplicateStamp.php b/src/Symfony/Component/Messenger/Stamp/DeduplicateStamp.php
@@ -15,14 +15,11 @@
 
 final class DeduplicateStamp implements StampInterface
 {
-    private Key $key;
-
     public function __construct(
-        string $key,
+        private Key $key,
         private ?float $ttl = 300.0,
         private bool $onlyDeduplicateInQueue = false,
     ) {
-        $this->key = new Key($key);
     }
 
     public function onlyDeduplicateInQueue(): bool
diff --git a/src/Symfony/Component/Messenger/Tests/Middleware/DeduplicateMiddlewareTest.php b/src/Symfony/Component/Messenger/Tests/Middleware/DeduplicateMiddlewareTest.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Messenger\Tests\Middleware;
 
+use Symfony\Component\Lock\Key;
 use Symfony\Component\Lock\LockFactory;
 use Symfony\Component\Lock\Store\FlockStore;
 use Symfony\Component\Lock\Store\SemaphoreStore;
@@ -39,7 +40,7 @@ public function testDeduplicateMiddlewareIgnoreIfMessageIsNotLockable()
     public function testDeduplicateMiddlewareIfMessageHasKey()
     {
         $message = new DummyMessage('Hello');
-        $envelope = new Envelope($message, [new DeduplicateStamp('id')]);
+        $envelope = new Envelope($message, [new DeduplicateStamp(new Key('id'))]);
 
         if (SemaphoreStore::isSupported()) {
             $store = new SemaphoreStore();
@@ -53,7 +54,7 @@ public function testDeduplicateMiddlewareIfMessageHasKey()
         $this->assertNotNull($envelope->last(DeduplicateStamp::class));
 
         $message2 = new DummyMessage('Hello');
-        $envelope2 = new Envelope($message2, [new DeduplicateStamp('id')]);
+        $envelope2 = new Envelope($message2, [new DeduplicateStamp(new Key('id'))]);
 
         $decorator->handle($envelope2, $this->getStackMock(false));
 
@@ -62,7 +63,7 @@ public function testDeduplicateMiddlewareIfMessageHasKey()
         $decorator->handle($envelope, $this->getStackMock(true));
 
         $message3 = new DummyMessage('Hello');
-        $envelope3 = new Envelope($message3, [new DeduplicateStamp('id')]);
+        $envelope3 = new Envelope($message3, [new DeduplicateStamp(new Key('id'))]);
         $decorator->handle($envelope3, $this->getStackMock(true));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,14 +15,11 @@`
`15`	`15`
`16`	`16`	`final class DeduplicateStamp implements StampInterface`
`17`	`17`	`{`
`18`		`- private Key $key;`
`19`		`-`
`20`	`18`	`public function __construct(`
`21`		`- string $key,`
	`19`	`+ private Key $key,`
`22`	`20`	`private ?float $ttl = 300.0,`
`23`	`21`	`private bool $onlyDeduplicateInQueue = false,`
`24`	`22`	`) {`
`25`		`- $this->key = new Key($key);`
`26`	`23`	`}`
`27`	`24`
`28`	`25`	`public function onlyDeduplicateInQueue(): bool`