[Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of misses

nicolas-grekas · nicolas-grekas · commit 8b59d177db23 · 2018-08-23T17:04:29.000+02:00
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php
@@ -89,6 +89,7 @@ public function testDefaultOptions()
 
         $this->assertTrue($client->getOption(\Memcached::OPT_COMPRESSION));
         $this->assertSame(1, $client->getOption(\Memcached::OPT_BINARY_PROTOCOL));
+        $this->assertSame(1, $client->getOption(\Memcached::OPT_TCP_NODELAY));
         $this->assertSame(1, $client->getOption(\Memcached::OPT_LIBKETAMA_COMPATIBLE));
     }
 
diff --git a/src/Symfony/Component/Cache/Traits/MemcachedTrait.php b/src/Symfony/Component/Cache/Traits/MemcachedTrait.php
@@ -134,6 +134,7 @@ public static function createConnection($servers, array $options = array())
             $options = array_change_key_case($options, CASE_UPPER);
             $client->setOption(\Memcached::OPT_BINARY_PROTOCOL, true);
             $client->setOption(\Memcached::OPT_NO_BLOCK, true);
+            $client->setOption(\Memcached::OPT_TCP_NODELAY, true);
             if (!array_key_exists('LIBKETAMA_COMPATIBLE', $options) && !array_key_exists(\Memcached::OPT_LIBKETAMA_COMPATIBLE, $options)) {
                 $client->setOption(\Memcached::OPT_LIBKETAMA_COMPATIBLE, true);
             }

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ public function testDefaultOptions()`
`89`	`89`
`90`	`90`	`$this->assertTrue($client->getOption(\Memcached::OPT_COMPRESSION));`
`91`	`91`	`$this->assertSame(1, $client->getOption(\Memcached::OPT_BINARY_PROTOCOL));`
	`92`	`+ $this->assertSame(1, $client->getOption(\Memcached::OPT_TCP_NODELAY));`
`92`	`93`	`$this->assertSame(1, $client->getOption(\Memcached::OPT_LIBKETAMA_COMPATIBLE));`
`93`	`94`	`}`
`94`	`95`
Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ public static function createConnection($servers, array $options = array())`
`134`	`134`	`$options = array_change_key_case($options, CASE_UPPER);`
`135`	`135`	`$client->setOption(\Memcached::OPT_BINARY_PROTOCOL, true);`
`136`	`136`	`$client->setOption(\Memcached::OPT_NO_BLOCK, true);`
	`137`	`+ $client->setOption(\Memcached::OPT_TCP_NODELAY, true);`
`137`	`138`	`if (!array_key_exists('LIBKETAMA_COMPATIBLE', $options) && !array_key_exists(\Memcached::OPT_LIBKETAMA_COMPATIBLE, $options)) {`
`138`	`139`	`$client->setOption(\Memcached::OPT_LIBKETAMA_COMPATIBLE, true);`
`139`	`140`	`}`