Because PHP 8.4 is adding deprecation warnings for non-nullable parameters with null default, change typehints

sam-bee · sam-bee · commit 8c3511b978e4 · 2024-05-13T12:43:33.000+01:00
diff --git a/src/Symfony/Component/Validator/Validation.php b/src/Symfony/Component/Validator/Validation.php
@@ -40,7 +40,7 @@ public static function createCallable(Constraint|ValidatorInterface|null $constr
     /**
      * Creates a callable that returns true/false instead of throwing validation exceptions.
      *
-     * @return callable(mixed $value, ConstraintViolationListInterface &$violations = null): bool
+     * @return callable(mixed $value, ?ConstraintViolationListInterface &$violations = null): bool
      */
     public static function createIsValidCallable(Constraint|ValidatorInterface|null $constraintOrValidator = null, Constraint ...$constraints): callable
     {
diff --git a/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php b/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php
@@ -21,7 +21,7 @@ class TestHttpServer
     /**
      * @param string|null $workingDirectory
      */
-    public static function start(int $port = 8057/* , string $workingDirectory = null */): Process
+    public static function start(int $port = 8057/* , ?string $workingDirectory = null */): Process
     {
         $workingDirectory = \func_get_args()[1] ?? __DIR__.'/Fixtures/web';
 

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public static function createCallable(Constraint\|ValidatorInterface\|null $constr`
`40`	`40`	`/**`
`41`	`41`	`* Creates a callable that returns true/false instead of throwing validation exceptions.`
`42`	`42`	`*`
`43`		`- * @return callable(mixed $value, ConstraintViolationListInterface &$violations = null): bool`
	`43`	`+ * @return callable(mixed $value, ?ConstraintViolationListInterface &$violations = null): bool`
`44`	`44`	`*/`
`45`	`45`	`public static function createIsValidCallable(Constraint\|ValidatorInterface\|null $constraintOrValidator = null, Constraint ...$constraints): callable`
`46`	`46`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class TestHttpServer`
`21`	`21`	`/**`
`22`	`22`	`* @param string\|null $workingDirectory`
`23`	`23`	`*/`
`24`		`- public static function start(int $port = 8057/* , string $workingDirectory = null */): Process`
	`24`	`+ public static function start(int $port = 8057/* , ?string $workingDirectory = null */): Process`
`25`	`25`	`{`
`26`	`26`	`$workingDirectory = \func_get_args()[1] ?? __DIR__.'/Fixtures/web';`
`27`	`27`