feature #60171 [FrameworkBundle][RateLimiter] deprecate RateLimiterFactory alias (kbond)

nicolas-grekas · nicolas-grekas · commit 8e0d7dd63fcf · 2025-04-08T09:05:52.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [FrameworkBundle][RateLimiter] deprecate `RateLimiterFactory` alias | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | Fix #60155 (comment) | License | MIT Commits ------- e4aa3a5 [FrameworkBundle][RateLimiter] deprecate `RateLimiterFactory` alias
diff --git a/UPGRADE-7.3.md b/UPGRADE-7.3.md
@@ -59,6 +59,7 @@ FrameworkBundle
    because its default value will change in version 8.0
  * Deprecate the `--show-arguments` option of the `container:debug` command, as arguments are now always shown
  * Deprecate the `framework.validation.cache` config option
+ * Deprecate the `RateLimiterFactory` autowiring aliases, use `RateLimiterFactoryInterface` instead
  * Deprecate setting the `framework.profiler.collect_serializer_data` config option to `false`
 
    When set to `true`, normalizers must be injected using the `NormalizerInterface`, and not using any concrete implementation.
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -23,6 +23,7 @@ CHANGELOG
    the `#[AsController]` attribute is no longer required
  * Deprecate setting the `framework.profiler.collect_serializer_data` config option to `false`
  * Set `framework.rate_limiter.limiters.*.lock_factory` to `auto` by default
+ * Deprecate `RateLimiterFactory` autowiring aliases, use `RateLimiterFactoryInterface` instead
 
 7.2
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -3266,10 +3266,11 @@ private function registerRateLimiterConfiguration(array $config, ContainerBuilde
             $limiterConfig['id'] = $name;
             $limiter->replaceArgument(0, $limiterConfig);
 
-            $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');
+            $factoryAlias = $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');
 
             if (interface_exists(RateLimiterFactoryInterface::class)) {
                 $container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter');
+                $factoryAlias->setDeprecated('symfony/dependency-injection', '7.3', 'The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.');
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -3266,10 +3266,11 @@ private function registerRateLimiterConfiguration(array $config, ContainerBuilde`
`3266`	`3266`	`$limiterConfig['id'] = $name;`
`3267`	`3267`	`$limiter->replaceArgument(0, $limiterConfig);`
`3268`	`3268`
`3269`		`- $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');`
	`3269`	`+ $factoryAlias = $container->registerAliasForArgument($limiterId, RateLimiterFactory::class, $name.'.limiter');`
`3270`	`3270`
`3271`	`3271`	`if (interface_exists(RateLimiterFactoryInterface::class)) {`
`3272`	`3272`	`$container->registerAliasForArgument($limiterId, RateLimiterFactoryInterface::class, $name.'.limiter');`
	`3273`	`+ $factoryAlias->setDeprecated('symfony/dependency-injection', '7.3', 'The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.');`
`3273`	`3274`	`}`
`3274`	`3275`	`}`
`3275`	`3276`	`}`