bug #32567 [Messenger] pass transport name to factory (Tobion)

fabpot · fabpot · commit 9662246c93c2 · 2019-07-19T09:33:31.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] pass transport name to factory | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | yes | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #32526 | License | MIT | Doc PR | It's technically a new feature but so tiny I'd be happy to have it in 4.3 Commits ------- 59926c8 [Messenger] pass transport name to factory
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1722,7 +1722,7 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
 
             $transportDefinition = (new Definition(TransportInterface::class))
                 ->setFactory([new Reference('messenger.transport_factory'), 'createTransport'])
-                ->setArguments([$transport['dsn'], $transport['options'], new Reference($serializerId)])
+                ->setArguments([$transport['dsn'], $transport['options'] + ['transport_name' => $name], new Reference($serializerId)])
                 ->addTag('messenger.receiver', ['alias' => $name])
             ;
             $container->setDefinition($transportId = 'messenger.transport.'.$name, $transportDefinition);
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -704,7 +704,7 @@ public function testMessengerTransports()
         $this->assertEquals([new Reference('messenger.transport_factory'), 'createTransport'], $transportFactory);
         $this->assertCount(3, $transportArguments);
         $this->assertSame('amqp://localhost/%2f/messages?exchange_name=exchange_name', $transportArguments[0]);
-        $this->assertEquals(['queue' => ['name' => 'Queue']], $transportArguments[1]);
+        $this->assertEquals(['queue' => ['name' => 'Queue'], 'transport_name' => 'customised'], $transportArguments[1]);
         $this->assertEquals(new Reference('messenger.transport.native_php_serializer'), $transportArguments[2]);
 
         $this->assertTrue($container->hasDefinition('messenger.transport.amqp.factory'));

Original file line number	Diff line number	Diff line change
`@@ -1722,7 +1722,7 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder`
`1722`	`1722`
`1723`	`1723`	`$transportDefinition = (new Definition(TransportInterface::class))`
`1724`	`1724`	`->setFactory([new Reference('messenger.transport_factory'), 'createTransport'])`
`1725`		`- ->setArguments([$transport['dsn'], $transport['options'], new Reference($serializerId)])`
	`1725`	`+ ->setArguments([$transport['dsn'], $transport['options'] + ['transport_name' => $name], new Reference($serializerId)])`
`1726`	`1726`	`->addTag('messenger.receiver', ['alias' => $name])`
`1727`	`1727`	`;`
`1728`	`1728`	`$container->setDefinition($transportId = 'messenger.transport.'.$name, $transportDefinition);`