cs

Nyholm · Nyholm · commit 9686df0e433f · 2020-10-31T11:35:49.000+01:00
diff --git a/src/Symfony/Component/ErrorHandler/Exception/FlattenException.php b/src/Symfony/Component/ErrorHandler/Exception/FlattenException.php
@@ -278,17 +278,19 @@ public function setTraceFromThrowable(\Throwable $throwable): self
     public function setTrace($trace, $file = null, $line = null): self
     {
         $this->trace = [];
-        if ($file)
-        $this->trace[] = [
-            'namespace' => '',
-            'short_class' => '',
-            'class' => '',
-            'type' => '',
-            'function' => '',
-            'file' => $file,
-            'line' => $line,
-            'args' => [],
-        ];
+        if (null !== $file) {
+            $this->trace[] = [
+                'namespace' => '',
+                'short_class' => '',
+                'class' => '',
+                'type' => '',
+                'function' => '',
+                'file' => $file,
+                'line' => $line,
+                'args' => [],
+            ];
+        }
+
         foreach ($trace as $entry) {
             $class = '';
             $namespace = '';
@@ -358,14 +360,14 @@ private function getClassNameFromIncomplete(\__PHP_Incomplete_Class $value): str
 
     public function getTraceAsString(): string
     {
-        if ($this->traceAsString === null) {
+        if (null === $this->traceAsString) {
             $this->traceAsString = '';
-            if ($this->trace !== null) {
+            if (null !== $this->trace) {
                 foreach ($this->trace as $i => $trace) {
-                    if ($i === 0) {
+                    if (0 === $i) {
                         continue;
                     }
-                    $this->traceAsString .= sprintf('#%d %s(%s): %s%s%s()', $i-1, $trace['file'], $trace['line'], $trace['class'], $trace['type'], $trace['function']).PHP_EOL;
+                    $this->traceAsString .= sprintf('#%d %s(%s): %s%s%s()', $i - 1, $trace['file'], $trace['line'], $trace['class'], $trace['type'], $trace['function']).\PHP_EOL;
                 }
             }
         }
diff --git a/src/Symfony/Component/ErrorHandler/Tests/Exception/FlattenExceptionTest.php b/src/Symfony/Component/ErrorHandler/Tests/Exception/FlattenExceptionTest.php
@@ -422,7 +422,7 @@ public function testSerialize()
 
         // Verify that they look kind of similar.
         $this->assertEquals(substr($trace, 0, 100), substr($restoredTrace, 0, 100));
-        $this->assertEquals(count(explode(PHP_EOL, $trace)), count(explode(PHP_EOL, $restoredTrace)));
+        $this->assertEquals(\count(explode(\PHP_EOL, $trace)), \count(explode(\PHP_EOL, $restoredTrace)));
     }
 
     private function createException($foo): \Exception
diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php
@@ -610,7 +610,7 @@ private function getWriteInfo(string $class, string $property, $value): Property
             'enable_magic_methods_extraction' => $this->magicMethodsFlags,
             'enable_constructor_extraction' => false,
             'enable_adder_remover_extraction' => $useAdderAndRemover,
-            'value' => $value
+            'value' => $value,
         ]);
 
         if (isset($item)) {
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
@@ -390,7 +390,7 @@ public function getWriteInfo(string $class, string $property, array $context = [
             $method = $reflClass->getMethod($methodName);
             /** @var \ReflectionParameter $parameter */
             $parameter = $method->getParameters()[0];
-            if (array_key_exists('value', $context) && $context['value'] === null && !$parameter->allowsNull()) {
+            if (\array_key_exists('value', $context) && null === $context['value'] && !$parameter->allowsNull()) {
                 $errors[] = sprintf('The method "%s" in class "%s" was found but does not allow null.', $methodName, $class);
                 continue;
             }

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ public function testSerialize()`
`422`	`422`
`423`	`423`	`// Verify that they look kind of similar.`
`424`	`424`	`$this->assertEquals(substr($trace, 0, 100), substr($restoredTrace, 0, 100));`
`425`		`- $this->assertEquals(count(explode(PHP_EOL, $trace)), count(explode(PHP_EOL, $restoredTrace)));`
	`425`	`+ $this->assertEquals(\count(explode(\PHP_EOL, $trace)), \count(explode(\PHP_EOL, $restoredTrace)));`
`426`	`426`	`}`
`427`	`427`
`428`	`428`	`private function createException($foo): \Exception`
Original file line number	Diff line number	Diff line change
`@@ -390,7 +390,7 @@ public function getWriteInfo(string $class, string $property, array $context = [`
`390`	`390`	`$method = $reflClass->getMethod($methodName);`
`391`	`391`	`/** @var \ReflectionParameter $parameter */`
`392`	`392`	`$parameter = $method->getParameters()[0];`
`393`		`- if (array_key_exists('value', $context) && $context['value'] === null && !$parameter->allowsNull()) {`
	`393`	`+ if (\array_key_exists('value', $context) && null === $context['value'] && !$parameter->allowsNull()) {`
`394`	`394`	`$errors[] = sprintf('The method "%s" in class "%s" was found but does not allow null.', $methodName, $class);`
`395`	`395`	`continue;`
`396`	`396`	`}`