bug #32156 [Workflow] re-add workflow.definition tag to workflow services (nikossvnk)

fabpot · fabpot · commit 9830c64db093 · 2019-06-25T14:31:05.000+02:00
This PR was squashed before being merged into the 4.3 branch (closes #32156). Discussion ---------- [Workflow] re-add workflow.definition tag to workflow services | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #32155  | License | MIT | Doc PR | Add again the `workflow.definition` tag in workflow services. Commits ------- 4df2dc5 [Workflow] re-add workflow.definition tag to workflow services
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -652,6 +652,10 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
             $definitionDefinition->addArgument($transitions);
             $definitionDefinition->addArgument($initialMarking);
             $definitionDefinition->addArgument($metadataStoreDefinition);
+            $definitionDefinition->addTag('workflow.definition', [
+                'name' => $name,
+                'type' => $type,
+            ]);
 
             // Create MarkingStore
             if (isset($workflow['marking_store']['type'])) {
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -311,6 +311,8 @@ public function testWorkflowLegacy()
             $workflowDefinition->getArgument(0),
             'Places are passed to the workflow definition'
         );
+
+        $this->assertSame(['workflow.definition' => [['name' => 'legacy', 'type' => 'state_machine']]], $workflowDefinition->getTags());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -311,6 +311,8 @@ public function testWorkflowLegacy()`
`311`	`311`	`$workflowDefinition->getArgument(0),`
`312`	`312`	`'Places are passed to the workflow definition'`
`313`	`313`	`);`
	`314`	`+`
	`315`	`+ $this->assertSame(['workflow.definition' => [['name' => 'legacy', 'type' => 'state_machine']]], $workflowDefinition->getTags());`
`314`	`316`	`}`
`315`	`317`
`316`	`318`	`/**`