[Workflow] Catch error when trying to get an uninitialized marking

lyrixx · lyrixx · commit 983e9035b0df · 2022-04-12T10:15:53.000+02:00
diff --git a/src/Symfony/Component/Workflow/MarkingStore/MethodMarkingStore.php b/src/Symfony/Component/Workflow/MarkingStore/MethodMarkingStore.php
@@ -54,7 +54,14 @@ public function getMarking($subject): Marking
             throw new LogicException(sprintf('The method "%s::%s()" does not exist.', \get_class($subject), $method));
         }
 
-        $marking = $subject->{$method}();
+        $marking = null;
+        try {
+            $marking = $subject->{$method}();
+        } catch (\Error $e) {
+            if (!preg_match('/^Typed property ([\w\\\\@]+)::\$(\w+) must not be accessed before initialization$/', $e->getMessage())) {
+                throw $e;
+            }
+        }
 
         if (null === $marking) {
             return new Marking();
diff --git a/src/Symfony/Component/Workflow/Tests/MarkingStore/MethodMarkingStoreTest.php b/src/Symfony/Component/Workflow/Tests/MarkingStore/MethodMarkingStoreTest.php
@@ -78,6 +78,21 @@ public function testGetMarkingWithValueObject()
         $this->assertSame('first_place', (string) $subject->getMarking());
     }
 
+    /**
+     * @requires PHP 7.4
+     */
+    public function testGetMarkingWithUninitializedProperty()
+    {
+        $subject = new SubjectWithType();
+
+        $markingStore = new MethodMarkingStore(true);
+
+        $marking = $markingStore->getMarking($subject);
+
+        $this->assertInstanceOf(Marking::class, $marking);
+        $this->assertCount(0, $marking->getPlaces());
+    }
+
     private function createValueObject(string $markingValue)
     {
         return new class($markingValue) {
diff --git a/src/Symfony/Component/Workflow/Tests/MarkingStore/SubjectWithType.php b/src/Symfony/Component/Workflow/Tests/MarkingStore/SubjectWithType.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace Symfony\Component\Workflow\Tests\MarkingStore;
+
+class SubjectWithType
+{
+    private string $marking;
+
+    public function getMarking(): string
+    {
+        return $this->marking;
+    }
+
+    public function setMarking(string $type): void
+    {
+        $this->marking = $type;
+    }
+}
