Added local cache for the discriminator resolver

sroze · sroze · commit 9e12d44f2b3b · 2017-10-01T18:51:39.000+02:00
diff --git a/src/Symfony/Component/Serializer/Mapping/ClassDiscriminatorFromClassMetadata.php b/src/Symfony/Component/Serializer/Mapping/ClassDiscriminatorFromClassMetadata.php
@@ -22,6 +22,7 @@ class ClassDiscriminatorFromClassMetadata implements ClassDiscriminatorResolverI
      * @var ClassMetadataFactoryInterface
      */
     private $classMetadataFactory;
+    private $mappingForMappedObjectCache = [];
 
     public function __construct(ClassMetadataFactoryInterface $classMetadataFactory)
     {
@@ -53,18 +54,12 @@ public function getMappingForMappedObject($object)
             }
         }
 
-        $reflectionClass = new \ReflectionClass($object);
-        if ($parentClass = $reflectionClass->getParentClass()) {
-            return $this->getMappingForMappedObject($parentClass->getName());
+        $cacheKey = is_object($object) ? get_class($object) : $object;
+        if (!array_key_exists($cacheKey, $this->mappingForMappedObjectCache)) {
+            $this->mappingForMappedObjectCache[$cacheKey] = $this->resolveMappingForMappedObject($object);
         }
 
-        foreach ($reflectionClass->getInterfaceNames() as $interfaceName) {
-            if (null !== ($interfaceMapping = $this->getMappingForMappedObject($interfaceName))) {
-                return $interfaceMapping;
-            }
-        }
-
-        return null;
+        return $this->mappingForMappedObjectCache[$cacheKey];
     }
 
     /**
@@ -78,4 +73,20 @@ public function getTypeForMappedObject($object)
 
         return $mapping->getMappedObjectType($object);
     }
+
+    private function resolveMappingForMappedObject($object)
+    {
+        $reflectionClass = new \ReflectionClass($object);
+        if ($parentClass = $reflectionClass->getParentClass()) {
+            return $this->getMappingForMappedObject($parentClass->getName());
+        }
+
+        foreach ($reflectionClass->getInterfaceNames() as $interfaceName) {
+            if (null !== ($interfaceMapping = $this->getMappingForMappedObject($interfaceName))) {
+                return $interfaceMapping;
+            }
+        }
+
+        return null;
+    }
 }
