bug #47280: [HttpFoundation] prevent incomplete profile dumps

DennisBirkholz · DennisBirkholz · commit a186c9f9c5d5 · 2022-08-15T13:30:27.000+02:00
diff --git a/src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
@@ -168,13 +168,14 @@ public function write(Profile $profile): bool
         ];
 
         $context = stream_context_create();
+        $wrapper = '';
 
         if (\function_exists('gzcompress')) {
-            $file = 'compress.zlib://'.$file;
+            $wrapper = 'compress.zlib://';
             stream_context_set_option($context, 'zlib', 'level', 3);
         }
 
-        if (false === file_put_contents($file, serialize($data), 0, $context)) {
+        if (false === file_put_contents($wrapper.$file.'.tmp', serialize($data), 0, $context) || false === rename($file.'.tmp', $file)) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -168,13 +168,14 @@ public function write(Profile $profile): bool`
`168`	`168`	`];`
`169`	`169`
`170`	`170`	`$context = stream_context_create();`
	`171`	`+ $wrapper = '';`
`171`	`172`
`172`	`173`	`if (\function_exists('gzcompress')) {`
`173`		`- $file = 'compress.zlib://'.$file;`
	`174`	`+ $wrapper = 'compress.zlib://';`
`174`	`175`	`stream_context_set_option($context, 'zlib', 'level', 3);`
`175`	`176`	`}`
`176`	`177`
`177`		`- if (false === file_put_contents($file, serialize($data), 0, $context)) {`
	`178`	`+ if (false === file_put_contents($wrapper.$file.'.tmp', serialize($data), 0, $context) \|\| false === rename($file.'.tmp', $file)) {`
`178`	`179`	`return false;`
`179`	`180`	`}`
`180`	`181`