Skip to content

Commit a314c4f

Browse files
xabbuhxabbuh
committed
deprecate not implementing data provider methods
1 parent 4511394 commit a314c4f

File tree

160 files changed

+823
-339
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

160 files changed

+823
-339
lines changed

‎UPGRADE-7.2.md

+8
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ Messenger
5252

5353
* Add `getRetryDelay()` method to `RecoverableExceptionInterface`
5454

55+
Notifier
56+
--------
57+
58+
* Deprecate `TransportFactoryTestCase`, implement `AbstractTransportFactoryTestCase` instead
59+
60+
The `testIncompleteDsnException()` and `testMissingRequiredOptionException()` tests are no longer provided by default. If you make use of them (i.e. by implementing the
61+
`incompleteDsnProvider()` or `missingRequiredOptionProvider()` data providers), you now need to use the `IncompleteDsnTestTrait` or `MissingRequiredOptionTestTrait` respectively.
62+
5563
Security
5664
--------
5765

‎src/Symfony/Component/Notifier/Bridge/AllMySms/Tests/AllMySmsTransportFactoryTest.php

+11-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
namespace Symfony\Component\Notifier\Bridge\AllMySms\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\AllMySms\AllMySmsTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

17-
final class AllMySmsTransportFactoryTest extends TransportFactoryTestCase
18+
final class AllMySmsTransportFactoryTest extends AbstractTransportFactoryTestCase
1819
{
20+
use IncompleteDsnTestTrait;
21+
1922
public function createFactory(): AllMySmsTransportFactory
2023
{
2124
return new AllMySmsTransportFactory();
@@ -44,4 +47,10 @@ public static function unsupportedSchemeProvider(): iterable
4447
{
4548
yield ['somethingElse://login:apiKey@default'];
4649
}
50+
51+
public static function incompleteDsnProvider(): iterable
52+
{
53+
yield ['allmysms://login@default'];
54+
yield ['allmysms://:apiKey@default'];
55+
}
4756
}

‎src/Symfony/Component/Notifier/Bridge/AllMySms/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\AllMySms\\": "" },

‎src/Symfony/Component/Notifier/Bridge/AmazonSns/Tests/AmazonSnsTransportFactoryTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
namespace Symfony\Component\Notifier\Bridge\AmazonSns\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\AmazonSns\AmazonSnsTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
1616

17-
class AmazonSnsTransportFactoryTest extends TransportFactoryTestCase
17+
class AmazonSnsTransportFactoryTest extends AbstractTransportFactoryTestCase
1818
{
1919
public function createFactory(): AmazonSnsTransportFactory
2020
{

‎src/Symfony/Component/Notifier/Bridge/AmazonSns/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0",
21+
"symfony/notifier": "^7.2",
2222
"async-aws/sns": "^1.0"
2323
},
2424
"autoload": {

‎src/Symfony/Component/Notifier/Bridge/Bandwidth/Tests/BandwidthTransportFactoryTest.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@
1212
namespace Symfony\Component\Notifier\Bridge\Bandwidth\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Bandwidth\BandwidthTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618

17-
final class BandwidthTransportFactoryTest extends TransportFactoryTestCase
19+
final class BandwidthTransportFactoryTest extends AbstractTransportFactoryTestCase
1820
{
21+
use IncompleteDsnTestTrait;
22+
use MissingRequiredOptionTestTrait;
23+
1924
public function createFactory(): BandwidthTransportFactory
2025
{
2126
return new BandwidthTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Bandwidth/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"require": {
2222
"php": ">=8.2",
2323
"symfony/http-client": "^6.4|^7.0",
24-
"symfony/notifier": "^6.4|^7.0"
24+
"symfony/notifier": "^7.2"
2525
},
2626
"require-dev": {
2727
"symfony/event-dispatcher": "^6.4|^7.0"

‎src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportFactoryTest.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
namespace Symfony\Component\Notifier\Bridge\Bluesky\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Bluesky\BlueskyTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

17-
class BlueskyTransportFactoryTest extends TransportFactoryTestCase
18+
class BlueskyTransportFactoryTest extends AbstractTransportFactoryTestCase
1819
{
20+
use IncompleteDsnTestTrait;
21+
1922
public function createFactory(): BlueskyTransportFactory
2023
{
2124
return new BlueskyTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Brevo/Tests/BrevoTransportFactoryTest.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@
1212
namespace Symfony\Component\Notifier\Bridge\Brevo\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Brevo\BrevoTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618

17-
final class BrevoTransportFactoryTest extends TransportFactoryTestCase
19+
final class BrevoTransportFactoryTest extends AbstractTransportFactoryTestCase
1820
{
21+
use IncompleteDsnTestTrait;
22+
use MissingRequiredOptionTestTrait;
23+
1924
public function createFactory(): BrevoTransportFactory
2025
{
2126
return new BrevoTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Brevo/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"require-dev": {
2424
"symfony/event-dispatcher": "^5.4|^6.0|^7.0"

‎src/Symfony/Component/Notifier/Bridge/Chatwork/Tests/ChatworkTransportFactoryTest.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,16 @@
1212
namespace Symfony\Component\Notifier\Bridge\Chatwork\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Chatwork\ChatworkTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618
use Symfony\Component\Notifier\Transport\TransportFactoryInterface;
1719

18-
class ChatworkTransportFactoryTest extends TransportFactoryTestCase
20+
class ChatworkTransportFactoryTest extends AbstractTransportFactoryTestCase
1921
{
22+
use IncompleteDsnTestTrait;
23+
use MissingRequiredOptionTestTrait;
24+
2025
public function createFactory(): TransportFactoryInterface
2126
{
2227
return new ChatworkTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Chatwork/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\Chatwork\\": "" },

‎src/Symfony/Component/Notifier/Bridge/ClickSend/Tests/ClickSendTransportFactoryTest.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
namespace Symfony\Component\Notifier\Bridge\ClickSend\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\ClickSend\ClickSendTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

17-
final class ClickSendTransportFactoryTest extends TransportFactoryTestCase
18+
final class ClickSendTransportFactoryTest extends AbstractTransportFactoryTestCase
1819
{
20+
use IncompleteDsnTestTrait;
21+
1922
public function createFactory(): ClickSendTransportFactory
2023
{
2124
return new ClickSendTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/ClickSend/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"require": {
2222
"php": ">=8.2",
2323
"symfony/http-client": "^6.4|^7.0",
24-
"symfony/notifier": "^6.4|^7.0"
24+
"symfony/notifier": "^7.2"
2525
},
2626
"require-dev": {
2727
"symfony/event-dispatcher": "^6.4|^7.0"

‎src/Symfony/Component/Notifier/Bridge/Clickatell/Tests/ClickatellTransportFactoryTest.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
namespace Symfony\Component\Notifier\Bridge\Clickatell\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Clickatell\ClickatellTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

17-
class ClickatellTransportFactoryTest extends TransportFactoryTestCase
18+
class ClickatellTransportFactoryTest extends AbstractTransportFactoryTestCase
1819
{
20+
use IncompleteDsnTestTrait;
21+
1922
public function createFactory(): ClickatellTransportFactory
2023
{
2124
return new ClickatellTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Clickatell/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"require": {
2323
"php": ">=8.2",
2424
"symfony/http-client": "^6.4|^7.0",
25-
"symfony/notifier": "^6.4|^7.0"
25+
"symfony/notifier": "^7.2"
2626
},
2727
"autoload": {
2828
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\Clickatell\\": "" },

‎src/Symfony/Component/Notifier/Bridge/ContactEveryone/Tests/ContactEveryoneTransportFactoryTest.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
namespace Symfony\Component\Notifier\Bridge\ContactEveryone\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\ContactEveryone\ContactEveryoneTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

17-
final class ContactEveryoneTransportFactoryTest extends TransportFactoryTestCase
18+
final class ContactEveryoneTransportFactoryTest extends AbstractTransportFactoryTestCase
1819
{
20+
use IncompleteDsnTestTrait;
21+
1922
public function createFactory(): ContactEveryoneTransportFactory
2023
{
2124
return new ContactEveryoneTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/ContactEveryone/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\ContactEveryone\\": "" },

‎src/Symfony/Component/Notifier/Bridge/Discord/Tests/DiscordTransportFactoryTest.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@
1212
namespace Symfony\Component\Notifier\Bridge\Discord\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Discord\DiscordTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618

17-
final class DiscordTransportFactoryTest extends TransportFactoryTestCase
19+
final class DiscordTransportFactoryTest extends AbstractTransportFactoryTestCase
1820
{
21+
use IncompleteDsnTestTrait;
22+
use MissingRequiredOptionTestTrait;
23+
1924
public function createFactory(): DiscordTransportFactory
2025
{
2126
return new DiscordTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Discord/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0",
21+
"symfony/notifier": "^7.2",
2222
"symfony/polyfill-mbstring": "^1.0"
2323
},
2424
"autoload": {

‎src/Symfony/Component/Notifier/Bridge/Engagespot/Tests/EngagespotTransportFactoryTest.php

+10-2
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,16 @@
1212
namespace Symfony\Component\Notifier\Bridge\Engagespot\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Engagespot\EngagespotTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
1617

1718
/**
1819
* @author Daniel GORGAN <https://github.com/danut007ro>
1920
*/
20-
final class EngagespotTransportFactoryTest extends TransportFactoryTestCase
21+
final class EngagespotTransportFactoryTest extends AbstractTransportFactoryTestCase
2122
{
23+
use IncompleteDsnTestTrait;
24+
2225
public function createFactory(): EngagespotTransportFactory
2326
{
2427
return new EngagespotTransportFactory();
@@ -42,4 +45,9 @@ public static function unsupportedSchemeProvider(): iterable
4245
{
4346
yield ['somethingElse://username:password@default'];
4447
}
48+
49+
public static function incompleteDsnProvider(): iterable
50+
{
51+
yield ['engagespot://default'];
52+
}
4553
}

‎src/Symfony/Component/Notifier/Bridge/Engagespot/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\Engagespot\\": "" },

‎src/Symfony/Component/Notifier/Bridge/Esendex/Tests/EsendexTransportFactoryTest.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@
1212
namespace Symfony\Component\Notifier\Bridge\Esendex\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Esendex\EsendexTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618

17-
final class EsendexTransportFactoryTest extends TransportFactoryTestCase
19+
final class EsendexTransportFactoryTest extends AbstractTransportFactoryTestCase
1820
{
21+
use IncompleteDsnTestTrait;
22+
use MissingRequiredOptionTestTrait;
23+
1924
public function createFactory(): EsendexTransportFactory
2025
{
2126
return new EsendexTransportFactory();

‎src/Symfony/Component/Notifier/Bridge/Esendex/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\Esendex\\": "" },

‎src/Symfony/Component/Notifier/Bridge/Expo/Tests/ExpoTransportFactoryTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
namespace Symfony\Component\Notifier\Bridge\Expo\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\Expo\ExpoTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
1616

1717
/**
1818
* @author Imad ZAIRIG <https://github.com/zairigimad>
1919
*/
20-
final class ExpoTransportFactoryTest extends TransportFactoryTestCase
20+
final class ExpoTransportFactoryTest extends AbstractTransportFactoryTestCase
2121
{
2222
public function createFactory(): ExpoTransportFactory
2323
{

‎src/Symfony/Component/Notifier/Bridge/Expo/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.2",
2020
"symfony/http-client": "^6.4|^7.0",
21-
"symfony/notifier": "^6.4|^7.0"
21+
"symfony/notifier": "^7.2"
2222
},
2323
"autoload": {
2424
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\Expo\\": "" },

‎src/Symfony/Component/Notifier/Bridge/FakeChat/Tests/FakeChatTransportFactoryTest.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,16 @@
1515
use Symfony\Component\Mailer\MailerInterface;
1616
use Symfony\Component\Notifier\Bridge\FakeChat\FakeChatTransportFactory;
1717
use Symfony\Component\Notifier\Exception\LogicException;
18-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
18+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
19+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
20+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1921
use Symfony\Component\Notifier\Transport\Dsn;
2022

21-
final class FakeChatTransportFactoryTest extends TransportFactoryTestCase
23+
final class FakeChatTransportFactoryTest extends AbstractTransportFactoryTestCase
2224
{
25+
use IncompleteDsnTestTrait;
26+
use MissingRequiredOptionTestTrait;
27+
2328
public function testMissingRequiredMailerDependency()
2429
{
2530
$this->expectException(LogicException::class);

‎src/Symfony/Component/Notifier/Bridge/FakeChat/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"require": {
2424
"php": ">=8.2",
2525
"symfony/http-client": "^6.4|^7.0",
26-
"symfony/notifier": "^6.4|^7.0"
26+
"symfony/notifier": "^7.2"
2727
},
2828
"require-dev": {
2929
"psr/log": "^1|^2|^3",

0 commit comments

Comments
 (0)