Expect deprecation in tests

simonberger · simonberger · commit a366f53c4bf9 · 2023-03-15T15:20:11.000+01:00
diff --git a/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php b/src/Symfony/Component/HttpClient/Tests/HttplugClientTest.php
@@ -18,6 +18,7 @@
 use Http\Promise\Promise;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ResponseInterface;
+use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
 use Symfony\Component\HttpClient\Exception\TransportException;
 use Symfony\Component\HttpClient\HttplugClient;
 use Symfony\Component\HttpClient\MockHttpClient;
@@ -27,13 +28,20 @@
 
 class HttplugClientTest extends TestCase
 {
+    use ExpectDeprecationTrait;
+
     public static function setUpBeforeClass(): void
     {
         TestHttpServer::start();
     }
 
+    /**
+     * @group legacy
+     */
     public function testSendRequest()
     {
+        $this->expectDeprecation('Since symfony/http-client 6.3: The "Symfony\Component\HttpClient\HttplugClient::sendRequest()" method is deprecated, use "Psr\Http\Client\ClientInterface::sendRequest()" instead.');
+
         $client = new HttplugClient(new NativeHttpClient());
 
         $response = $client->sendRequest($client->createRequest('GET', 'http://localhost:8057'));
@@ -103,8 +111,13 @@ public function testWait()
         $this->assertFalse($failureCallableCalled, 'Failure callable should not be called when request is successful.');
     }
 
+    /**
+     * @group legacy
+     */
     public function testPostRequest()
     {
+        $this->expectDeprecation('Since symfony/http-client 6.3: The "Symfony\Component\HttpClient\HttplugClient::sendRequest()" method is deprecated, use "Psr\Http\Client\ClientInterface::sendRequest()" instead.');
+
         $client = new HttplugClient(new NativeHttpClient());
 
         $request = $client->createRequest('POST', 'http://localhost:8057/post')
@@ -116,8 +129,13 @@ public function testPostRequest()
         $this->assertSame(['foo' => '0123456789', 'REQUEST_METHOD' => 'POST'], $body);
     }
 
+    /**
+     * @group legacy
+     */
     public function testNetworkException()
     {
+        $this->expectDeprecation('Since symfony/http-client 6.3: The "Symfony\Component\HttpClient\HttplugClient::sendRequest()" method is deprecated, use "Psr\Http\Client\ClientInterface::sendRequest()" instead.');
+
         $client = new HttplugClient(new NativeHttpClient());
 
         $this->expectException(NetworkException::class);
@@ -150,8 +168,13 @@ public function testAsyncNetworkException()
         $promise->wait(true);
     }
 
+    /**
+     * @group legacy
+     */
     public function testRequestException()
     {
+        $this->expectDeprecation('Since symfony/http-client 6.3: The "Symfony\Component\HttpClient\HttplugClient::sendRequest()" method is deprecated, use "Psr\Http\Client\ClientInterface::sendRequest()" instead.');
+
         $client = new HttplugClient(new NativeHttpClient());
 
         $this->expectException(RequestException::class);
