[TypeInfo] Add space after glue comma

ruudk · nicolas-grekas · commit a58ddf5edea0 · 2025-08-19T15:33:21.000+02:00
With this change, it will print a collection type as `array&lt;key, value&gt;` instead of
`array&lt;key,value&gt;`.

I believe it is more standard than without the space. It's also what Symfony itself does
everywhere.
diff --git a/src/Symfony/Component/TypeInfo/Tests/Type/CollectionTypeTest.php b/src/Symfony/Component/TypeInfo/Tests/Type/CollectionTypeTest.php
@@ -89,7 +89,7 @@ public function testToString()
         $this->assertEquals('array<bool>', (string) $type);
 
         $type = new CollectionType(new GenericType(Type::builtin(TypeIdentifier::ARRAY), Type::string(), Type::bool()));
-        $this->assertEquals('array<string,bool>', (string) $type);
+        $this->assertEquals('array<string, bool>', (string) $type);
 
         $type = new CollectionType(Type::generic(Type::builtin(TypeIdentifier::ARRAY), Type::bool()), isList: true);
         $this->assertEquals('list<bool>', (string) $type);
diff --git a/src/Symfony/Component/TypeInfo/Tests/Type/GenericTypeTest.php b/src/Symfony/Component/TypeInfo/Tests/Type/GenericTypeTest.php
@@ -31,10 +31,10 @@ public function testToString()
         $this->assertEquals('array<bool>', (string) $type);
 
         $type = new GenericType(Type::builtin(TypeIdentifier::ARRAY), Type::string(), Type::bool());
-        $this->assertEquals('array<string,bool>', (string) $type);
+        $this->assertEquals('array<string, bool>', (string) $type);
 
         $type = new GenericType(Type::object(self::class), Type::union(Type::bool(), Type::string()), Type::int(), Type::float());
-        $this->assertEquals(\sprintf('%s<bool|string,int,float>', self::class), (string) $type);
+        $this->assertEquals(\sprintf('%s<bool|string, int, float>', self::class), (string) $type);
     }
 
     public function testWrappedTypeIsSatisfiedBy()
diff --git a/src/Symfony/Component/TypeInfo/Type/GenericType.php b/src/Symfony/Component/TypeInfo/Type/GenericType.php
@@ -72,7 +72,7 @@ public function __toString(): string
         $glue = '';
         foreach ($this->variableTypes as $t) {
             $variableTypesString .= $glue.$t;
-            $glue = ',';
+            $glue = ', ';
         }
 
         return $typeString.'<'.$variableTypesString.'>';
diff --git a/src/Symfony/Component/TypeInfo/TypeFactoryTrait.php b/src/Symfony/Component/TypeInfo/TypeFactoryTrait.php
@@ -240,7 +240,7 @@ public static function object(?string $className = null): BuiltinType|ObjectType
      * @param T      $className
      * @param U|null $backingType
      *
-     * @return ($className is class-string<\BackedEnum> ? ($backingType is U ? BackedEnumType<T,U> : BackedEnumType<T,BuiltinType<TypeIdentifier::INT>|BuiltinType<TypeIdentifier::STRING>>) : EnumType<T>))
+     * @return ($className is class-string<\BackedEnum> ? ($backingType is U ? BackedEnumType<T, U> : BackedEnumType<T, BuiltinType<TypeIdentifier::INT>|BuiltinType<TypeIdentifier::STRING>>) : EnumType<T>))
      */
     public static function enum(string $className, ?BuiltinType $backingType = null): EnumType
     {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function __toString(): string`
`72`	`72`	`$glue = '';`
`73`	`73`	`foreach ($this->variableTypes as $t) {`
`74`	`74`	`$variableTypesString .= $glue.$t;`
`75`		`- $glue = ',';`
	`75`	`+ $glue = ', ';`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`return $typeString.'<'.$variableTypesString.'>';`
Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ public static function object(?string $className = null): BuiltinType\|ObjectType`
`240`	`240`	`* @param T $className`
`241`	`241`	`* @param U\|null $backingType`
`242`	`242`	`*`
`243`		`- * @return ($className is class-string<\BackedEnum> ? ($backingType is U ? BackedEnumType<T,U> : BackedEnumType<T,BuiltinType<TypeIdentifier::INT>\|BuiltinType<TypeIdentifier::STRING>>) : EnumType<T>))`
	`243`	`+ * @return ($className is class-string<\BackedEnum> ? ($backingType is U ? BackedEnumType<T, U> : BackedEnumType<T, BuiltinType<TypeIdentifier::INT>\|BuiltinType<TypeIdentifier::STRING>>) : EnumType<T>))`
`244`	`244`	`*/`
`245`	`245`	`public static function enum(string $className, ?BuiltinType $backingType = null): EnumType`
`246`	`246`	`{`