[HttpFoundation] Emit PHP warning when Response::sendHeaders() while output has already been sent

ivo95v · nicolas-grekas · commit a69cf15e51cd · 2025-05-10T10:43:59.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -317,6 +317,11 @@ public function sendHeaders(?int $statusCode = null): static
     {
         // headers have already been sent by the developer
         if (headers_sent()) {
+            if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {
+                $statusCode ??= $this->statusCode;
+                header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);
+            }
+
             return $this;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -317,6 +317,11 @@ public function sendHeaders(?int $statusCode = null): static`
`317`	`317`	`{`
`318`	`318`	`// headers have already been sent by the developer`
`319`	`319`	`if (headers_sent()) {`
	`320`	`+ if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {`
	`321`	`+ $statusCode ??= $this->statusCode;`
	`322`	`+ header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);`
	`323`	`+ }`
	`324`	`+`
`320`	`325`	`return $this;`
`321`	`326`	`}`
`322`	`327`