minor #40733 * LightSmsTransport.php - suggestion for pull request #40712 (StaffNowa)

chalasr · chalasr · commit a6b589e6d411 · 2021-04-08T00:13:02.000+02:00
This PR was merged into the 5.3-dev branch. Discussion ---------- * LightSmsTransport.php - suggestion for pull request #40712 | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #40712 | License | MIT | Doc PR | - After remove issets still get warnings about undefined variables. My solution for this: 1. Create method which have all issets cases. 2. Return (int) errorCode Commits ------- 0b1a450 * LightSmsTransport.php
diff --git a/src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b/src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
@@ -124,8 +124,8 @@ protected function doSend(MessageInterface $message): SentMessage
 
         $content = $response->toArray(false);
 
-        if (0 !== (int) $content[$phone]['error'] ?? -1) {
-            $errorCode = (int) $content['error'] ?? $content['']['error'] ?? $content[$phone]['error'] ?? -1;
+        if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) {
+            $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;
             if (-1 === $errorCode) {
                 throw new TransportException('Unable to send the SMS.', $response);
             }

Original file line number	Diff line number	Diff line change
`@@ -124,8 +124,8 @@ protected function doSend(MessageInterface $message): SentMessage`
`124`	`124`
`125`	`125`	`$content = $response->toArray(false);`
`126`	`126`
`127`		`- if (0 !== (int) $content[$phone]['error'] ?? -1) {`
`128`		`- $errorCode = (int) $content['error'] ?? $content['']['error'] ?? $content[$phone]['error'] ?? -1;`
	`127`	`+ if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) {`
	`128`	`+ $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;`
`129`	`129`	`if (-1 === $errorCode) {`
`130`	`130`	`throw new TransportException('Unable to send the SMS.', $response);`
`131`	`131`	`}`