minor #59701 [Process] skip transient test on GitHub Actions (xabbuh)

nicolas-grekas · nicolas-grekas · commit a96323208123 · 2025-02-05T09:35:22.000+01:00
This PR was merged into the 7.2 branch. Discussion ---------- [Process] skip transient test on GitHub Actions | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT same as #59690 for a transient test that was introduced with Symfony 7.1 in #53968 (#59700 added it to the wrong method 🙈) Commits ------- fc8ee6a skip transient test on GitHub Actions
diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -710,9 +710,6 @@ public function testProcessIsNotSignaled()
         if ('\\' === \DIRECTORY_SEPARATOR) {
             $this->markTestSkipped('Windows does not support POSIX signals');
         }
-        if (\PHP_VERSION_ID < 80300 && isset($_SERVER['GITHUB_ACTIONS'])) {
-            $this->markTestSkipped('Transient on GHA with PHP < 8.3');
-        }
 
         $process = $this->getProcess('echo foo');
         $process->run();
@@ -1689,6 +1686,9 @@ public function testNotIgnoringSignal()
         if (!\function_exists('pcntl_signal')) {
             $this->markTestSkipped('pnctl extension is required.');
         }
+        if (\PHP_VERSION_ID < 80300 && isset($_SERVER['GITHUB_ACTIONS'])) {
+            $this->markTestSkipped('Transient on GHA with PHP < 8.3');
+        }
 
         $process = $this->getProcess(['sleep', '10']);
 
