[ReflectionExtractor] Simplify feature gate with simple "PHP_VERSION_ID" comparison

pan93412 · pan93412 · commit aa1d379e58f3 · 2024-11-21T22:57:23.000+08:00
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
@@ -713,13 +713,7 @@ private function isAllowedProperty(string $class, string $property, bool $writeA
                 return false;
             }
 
-            // PHP 8.4: Asymmetric Visibility and Property Hooks
-            $hasAsymmetricVisibilityCapability = method_exists($reflectionProperty, 'isPrivateSet')
-                && method_exists($reflectionProperty, 'isProtectedSet')
-                && method_exists($reflectionProperty, 'isVirtual')
-                && method_exists($reflectionProperty, 'hasHook');
-
-            if ($hasAsymmetricVisibilityCapability) {
+            if (\PHP_VERSION_ID >= 80400) {
                 // If the property is virtual and has no setter, it's not writable.
                 if ($writeAccessRequired && $reflectionProperty->isVirtual() && !$reflectionProperty->hasHook(\PropertyHookType::Set)) {
                     return false;
@@ -969,15 +963,25 @@ private function getReadVisiblityForMethod(\ReflectionMethod $reflectionMethod):
 
     private function getWriteVisiblityForProperty(\ReflectionProperty $reflectionProperty): string
     {
-        // PHP 8.4: Property hooks
-        if (method_exists($reflectionProperty, 'isVirtual') && method_exists($reflectionProperty, 'hasHook')) {
+        if (\PHP_VERSION_ID >= 80400) {
+            // If the property is virtual and has no setter, it's private
             if ($reflectionProperty->isVirtual() && !$reflectionProperty->hasHook(\PropertyHookType::Set)) {
                 return PropertyWriteInfo::VISIBILITY_PRIVATE;
             }
+
+            // If the property has private setter, it's not writable
+            if ($reflectionProperty->isPrivateSet()) {
+                return PropertyWriteInfo::VISIBILITY_PRIVATE;
+            }
+
+            // If the property has protected setter, it's protected
+            if ($reflectionProperty->isProtectedSet()) {
+                return PropertyWriteInfo::VISIBILITY_PROTECTED;
+            }
         }
 
         // PHP 8.4: Asymmetric visibility
-        if (method_exists($reflectionProperty, 'isPrivateSet') && method_exists($reflectionProperty, 'isProtectedSet')) {
+        if (\PHP_VERSION_ID >= 80400) {
             if ($reflectionProperty->isPrivateSet()) {
                 return PropertyWriteInfo::VISIBILITY_PRIVATE;
             }
