Fix the list of supported shells for completions in a phar

stof · stof · commit aabdc2001112 · 2023-04-21T20:01:19.000+02:00
Using glob inside a phar does not work (it does not find anything).
Using a DirectoryIterator on the other hand works with phars. This
allows this command to compute the list of supported shells properly
when used inside a phar.
diff --git a/src/Symfony/Component/Console/Command/DumpCompletionCommand.php b/src/Symfony/Component/Console/Command/DumpCompletionCommand.php
@@ -132,8 +132,14 @@ private function tailDebugLog(string $commandName, OutputInterface $output): voi
      */
     private function getSupportedShells(): array
     {
-        return array_map(function ($f) {
-            return pathinfo($f, \PATHINFO_EXTENSION);
-        }, glob(__DIR__.'/../Resources/completion.*'));
+        $shells = [];
+
+        foreach (new \DirectoryIterator(__DIR__.'/../Resources/') as $file) {
+            if (str_starts_with($file->getBasename(), 'completion.') && $file->isFile()) {
+                $shells[] = $file->getExtension();
+            }
+        }
+
+        return $shells;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -132,8 +132,14 @@ private function tailDebugLog(string $commandName, OutputInterface $output): voi`
`132`	`132`	`*/`
`133`	`133`	`private function getSupportedShells(): array`
`134`	`134`	`{`
`135`		`- return array_map(function ($f) {`
`136`		`- return pathinfo($f, \PATHINFO_EXTENSION);`
`137`		`- }, glob(__DIR__.'/../Resources/completion.*'));`
	`135`	`+ $shells = [];`
	`136`	`+`
	`137`	`+ foreach (new \DirectoryIterator(__DIR__.'/../Resources/') as $file) {`
	`138`	`+ if (str_starts_with($file->getBasename(), 'completion.') && $file->isFile()) {`
	`139`	`+ $shells[] = $file->getExtension();`
	`140`	`+ }`
	`141`	`+ }`
	`142`	`+`
	`143`	`+ return $shells;`
`138`	`144`	`}`
`139`	`145`	`}`