minor #51111 [Runtime] Fix property must not be accessed before initialization on SymfonyRuntime (l-vo)

nicolas-grekas · nicolas-grekas · commit ad7224526179 · 2023-07-26T11:23:10.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Runtime] Fix property must not be accessed before initialization on SymfonyRuntime | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#...  Introduced by #51068, see #51068 (comment) Commits ------- dd3c406 Fix property must not be accessed before initialization on SymfonyRuntime::$input
diff --git a/src/Symfony/Component/Runtime/SymfonyRuntime.php b/src/Symfony/Component/Runtime/SymfonyRuntime.php
@@ -106,7 +106,7 @@ public function __construct(array $options = [])
                 ->usePutenv($options['use_putenv'] ?? false)
                 ->bootEnv($options['project_dir'].'/'.($options['dotenv_path'] ?? '.env'), 'dev', (array) ($options['test_envs'] ?? ['test']), $options['dotenv_overload'] ?? false);
 
-            if ($this->input && ($options['dotenv_overload'] ?? false)) {
+            if (isset($this->input) && ($options['dotenv_overload'] ?? false)) {
                 if ($this->input->getParameterOption(['--env', '-e'], $_SERVER[$envKey], true) !== $_SERVER[$envKey]) {
                     throw new \LogicException(sprintf('Cannot use "--env" or "-e" when the "%s" file defines "%s" and the "dotenv_overload" runtime option is true.', $options['dotenv_path'] ?? '.env', $envKey));
                 }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public function __construct(array $options = [])`
`106`	`106`	`->usePutenv($options['use_putenv'] ?? false)`
`107`	`107`	`->bootEnv($options['project_dir'].'/'.($options['dotenv_path'] ?? '.env'), 'dev', (array) ($options['test_envs'] ?? ['test']), $options['dotenv_overload'] ?? false);`
`108`	`108`
`109`		`- if ($this->input && ($options['dotenv_overload'] ?? false)) {`
	`109`	`+ if (isset($this->input) && ($options['dotenv_overload'] ?? false)) {`
`110`	`110`	`if ($this->input->getParameterOption(['--env', '-e'], $_SERVER[$envKey], true) !== $_SERVER[$envKey]) {`
`111`	`111`	`throw new \LogicException(sprintf('Cannot use "--env" or "-e" when the "%s" file defines "%s" and the "dotenv_overload" runtime option is true.', $options['dotenv_path'] ?? '.env', $envKey));`
`112`	`112`	`}`