[VarDumper] fix casting server attribute

jschaedl · jschaedl · commit ae08d2decff5 · 2018-09-27T18:43:45.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Caster/MemcachedCaster.php b/src/Symfony/Component/VarDumper/Caster/MemcachedCaster.php
@@ -20,17 +20,15 @@ class MemcachedCaster
 {
     public static function castMemcached(\Memcached $c, array $a, Stub $stub, $isNested)
     {
+        $servers = [];
         foreach ($c->getServerList() as $key => $serverData) {
-            $a += array(
-                Caster::PREFIX_VIRTUAL.'servers' => new EnumStub(
-                    array(
-                        'server_'.$key => new EnumStub($serverData),
-                    )
-                ),
-            );
+            $servers['server_'.$key] = new EnumStub($serverData);
         }
 
         $a += array(
+            Caster::PREFIX_VIRTUAL.'servers' => new EnumStub(
+                $servers
+            ),
             Caster::PREFIX_VIRTUAL.'options' => new EnumStub(
                 array(
                     'OPT_COMPRESSION' => $c->getOption(\Memcached::OPT_COMPRESSION),
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/MemcachedCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/MemcachedCasterTest.php
@@ -26,11 +26,16 @@ public function testCastMemcached()
 
         $var = new \Memcached();
 
-        $expectedServerHost = '127.0.0.1';
-        $expectedServerPort = 11211;
-        $expectedConnectionType = 'TCP';
+        $expectedServerHost1 = '127.0.0.1';
+        $expectedServerPort1 = 11211;
+        $expectedConnectionType1 = 'TCP';
 
-        $var->addServer($expectedServerHost, $expectedServerPort);
+        $expectedServerHost2 = '127.0.0.2';
+        $expectedServerPort2 = 11211;
+        $expectedConnectionType2 = 'TCP';
+
+        $var->addServer($expectedServerHost1, $expectedServerPort1);
+        $var->addServer($expectedServerHost2, $expectedServerPort2);
 
         $expectedOption1 = $var->getOption(\Memcached::OPT_COMPRESSION) ? 'true' : 'false';
         $expectedOption2 = $var->getOption(\Memcached::OPT_SERIALIZER);
@@ -56,9 +61,14 @@ public function testCastMemcached()
 Memcached {
   servers: {
     server_0: {
-      host: "$expectedServerHost"
-      port: $expectedServerPort
-      type: "$expectedConnectionType"
+      host: "$expectedServerHost1"
+      port: $expectedServerPort1
+      type: "$expectedConnectionType1"
+    }
+    server_1: {
+      host: "$expectedServerHost2"
+      port: $expectedServerPort2
+      type: "$expectedConnectionType2"
     }
   }
   options: {
