minor #36724 [HttpFoundation] fix perf of ResponseHeaderBag::initDate() (nicolas-grekas)

fabpot · fabpot · commit af160e2c3f8c · 2020-05-06T13:24:23.000+02:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpFoundation] fix perf of ResponseHeaderBag::initDate() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This change alone makes a skeleton hello world go from 1600 req/s to 1800 req/s on my machine (with preloading enabled to remove the cost of the autoloader). Another discovery by [![image](https://user-images.githubusercontent.com/243674/81168746-e00cf280-8f97-11ea-9f18-7e14e84b2828.png)](https://blackfire.io/) Commits ------- 1294cb5 [HttpFoundation] fix perf of ResponseHeaderBag::initDate()
diff --git a/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php b/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php
@@ -286,8 +286,6 @@ protected function computeCacheControlValue()
 
     private function initDate(): void
     {
-        $now = \DateTime::createFromFormat('U', time());
-        $now->setTimezone(new \DateTimeZone('UTC'));
-        $this->set('Date', $now->format('D, d M Y H:i:s').' GMT');
+        $this->set('Date', gmdate('D, d M Y H:i:s').' GMT');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -286,8 +286,6 @@ protected function computeCacheControlValue()`
`286`	`286`
`287`	`287`	`private function initDate(): void`
`288`	`288`	`{`
`289`		`- $now = \DateTime::createFromFormat('U', time());`
`290`		`- $now->setTimezone(new \DateTimeZone('UTC'));`
`291`		`- $this->set('Date', $now->format('D, d M Y H:i:s').' GMT');`
	`289`	`+ $this->set('Date', gmdate('D, d M Y H:i:s').' GMT');`
`292`	`290`	`}`
`293`	`291`	`}`