bug #26845 [Config] Fixing GlobResource when inside phar archive (vworldat)

nicolas-grekas · nicolas-grekas · commit b61c8fcb7728 · 2018-06-20T13:09:19.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Config] Fixing GlobResource when inside phar archive | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | yes if old broken behavior counts as stable | Deprecations? | no | Tests pass? | no tests yet | Fixed tickets | | License | MIT | Doc PR | N/A When packaging an Sf4 application as a PHAR archive using globs at various locations (`Kernel`, `services.yaml`) most glob files are not found because the `glob()` PHP method [does not support PHAR streams](https://stackoverflow.com/questions/8203188/unexpected-problems-with-php-phar). Using the regex fallback instead when operating inside PHAR archives fixes the behavior for me. ## Examples: `src/Kernel.php::configureContainer()`: ```php $loader->load($confDir.'/{services}'.self::CONFIG_EXTS, 'glob'); ``` Expected behavior: `config/services.yaml` inside PHAR archive is found and parsed Actual behavior: the file will not be loaded `config/services.yaml` (hard-coded in Kernel without using glob pattern) ```yaml App\: resource: '../src/*' exclude: '../src/{Entity,Migrations,Tests,Kernel.php}' ``` Expected behavior: service classes in `src/` will be found and auto-wired Actual behavior: services are not auto-wired because the class files are not found Commits ------- e336ebe Fixing GlobResource when inside phar archive
diff --git a/src/Symfony/Component/Config/Resource/GlobResource.php b/src/Symfony/Component/Config/Resource/GlobResource.php
@@ -93,7 +93,7 @@ public function getIterator()
             return;
         }
 
-        if (false === strpos($this->pattern, '/**/') && (defined('GLOB_BRACE') || false === strpos($this->pattern, '{'))) {
+        if (0 !== strpos($this->prefix, 'phar://') && false === strpos($this->pattern, '/**/') && (defined('GLOB_BRACE') || false === strpos($this->pattern, '{'))) {
             foreach (glob($this->prefix.$this->pattern, defined('GLOB_BRACE') ? GLOB_BRACE : 0) as $path) {
                 if ($this->recursive && is_dir($path)) {
                     $files = iterator_to_array(new \RecursiveIteratorIterator(

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public function getIterator()`
`93`	`93`	`return;`
`94`	`94`	`}`
`95`	`95`
`96`		`- if (false === strpos($this->pattern, '/**/') && (defined('GLOB_BRACE') \|\| false === strpos($this->pattern, '{'))) {`
	`96`	`+ if (0 !== strpos($this->prefix, 'phar://') && false === strpos($this->pattern, '/**/') && (defined('GLOB_BRACE') \|\| false === strpos($this->pattern, '{'))) {`
`97`	`97`	`foreach (glob($this->prefix.$this->pattern, defined('GLOB_BRACE') ? GLOB_BRACE : 0) as $path) {`
`98`	`98`	`if ($this->recursive && is_dir($path)) {`
`99`	`99`	`$files = iterator_to_array(new \RecursiveIteratorIterator(`