bug #40027 [DoctrineBridge] add missing @experimental annotation on Uid generators (nicolas-grekas)

fabpot · fabpot · commit b9094f4fd2f9 · 2021-01-28T15:59:42.000+01:00
This PR was merged into the 5.2 branch. Discussion ---------- [DoctrineBridge] add missing `@experimental` annotation on Uid generators | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Forgotten when we created the classes. Needed since I plan to remove all the `UuidV*` generators. They're useless and a more flexible approach based on doctrine/DoctrineBundle#1284 is coming. Commits ------- e380102 [DoctrineBridge] add missing `@experimental` annotation on Uid generators
diff --git a/src/Symfony/Bridge/Doctrine/CHANGELOG.md b/src/Symfony/Bridge/Doctrine/CHANGELOG.md
@@ -5,7 +5,7 @@ CHANGELOG
 -----
 
  * added support for symfony/uid as `UlidType` and `UuidType` as Doctrine types
- * added `UlidGenerator`, `UUidV1Generator`, `UuidV4Generator` and `UuidV6Generator`
+ * added `UlidGenerator`, `UuidV1Generator`, `UuidV4Generator` and `UuidV6Generator`
 
 5.0.0
 -----
diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UlidGenerator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UlidGenerator.php
@@ -15,6 +15,9 @@
 use Doctrine\ORM\Id\AbstractIdGenerator;
 use Symfony\Component\Uid\Ulid;
 
+/**
+ * @experimental in 5.2
+ */
 final class UlidGenerator extends AbstractIdGenerator
 {
     public function generate(EntityManager $em, $entity): Ulid
diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV1Generator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV1Generator.php
@@ -15,6 +15,9 @@
 use Doctrine\ORM\Id\AbstractIdGenerator;
 use Symfony\Component\Uid\UuidV1;
 
+/**
+ * @experimental in 5.2
+ */
 final class UuidV1Generator extends AbstractIdGenerator
 {
     public function generate(EntityManager $em, $entity): UuidV1
diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV4Generator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV4Generator.php
@@ -15,6 +15,9 @@
 use Doctrine\ORM\Id\AbstractIdGenerator;
 use Symfony\Component\Uid\UuidV4;
 
+/**
+ * @experimental in 5.2
+ */
 final class UuidV4Generator extends AbstractIdGenerator
 {
     public function generate(EntityManager $em, $entity): UuidV4
diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV6Generator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV6Generator.php
@@ -15,6 +15,9 @@
 use Doctrine\ORM\Id\AbstractIdGenerator;
 use Symfony\Component\Uid\UuidV6;
 
+/**
+ * @experimental in 5.2
+ */
 final class UuidV6Generator extends AbstractIdGenerator
 {
     public function generate(EntityManager $em, $entity): UuidV6

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,9 @@`
`15`	`15`	`use Doctrine\ORM\Id\AbstractIdGenerator;`
`16`	`16`	`use Symfony\Component\Uid\Ulid;`
`17`	`17`
	`18`	`+/**`
	`19`	`+ * @experimental in 5.2`
	`20`	`+ */`
`18`	`21`	`final class UlidGenerator extends AbstractIdGenerator`
`19`	`22`	`{`
`20`	`23`	`public function generate(EntityManager $em, $entity): Ulid`