minor #61608 [DependencyInjection] Optimize AutowireRequiredMethodsPass (HypeMC)

nicolas-grekas · nicolas-grekas · commit bae2c06d9ab8 · 2025-09-03T13:40:13.000+02:00
This PR was merged into the 7.4 branch. Discussion ---------- [DependencyInjection] Optimize `AutowireRequiredMethodsPass` | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After profiling container compilation, I noticed that `ReflectionMethod::getPrototype()` accounts for a significant percentage of the total time: <img width="1917" height="902" alt="Screenshot from 2025-09-03 12-51-13" src="https://github.com/user-attachments/assets/3bb72568-1c94-4dc5-b9f5-0eb94d9f91e8" /> Instead of calling `ReflectionMethod::getPrototype()` each time and wrapping it in a try/catch, this PR switches to using `ReflectionMethod::hasPrototype()`. Here are some stats before and after this change: **Before** ```bash $ rm -rf var/cache/dev/* $ time bin/console Symfony 7.3.3 (env: dev, debug: true) real 1m4.682s user 1m1.326s sys 0m3.330s $ rm -rf var/cache/prod/* $ time bin/console -e prod Symfony 7.3.3 (env: prod, debug: false) real 0m59.614s user 0m57.520s sys 0m2.033s ``` **After** ```bash $ rm -rf var/cache/dev/* $ time bin/console Symfony 7.3.3 (env: dev, debug: true) real 0m24.026s user 0m21.909s sys 0m2.109s $ rm -rf var/cache/prod/* $ time bin/console -e prod Symfony 7.3.3 (env: prod, debug: false) real 0m22.439s user 0m21.256s sys 0m1.138s ``` As far as I know, optimizations are considered features rather than bug fixes. If I'm wrong, please let me know and I'll retarget to 6.4. Commits ------- e8a05a0 [DependencyInjection] Optimize `AutowireRequiredMethodsPass`
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php
@@ -57,11 +57,10 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
                     }
                     break;
                 }
-                try {
-                    $r = $r->getPrototype();
-                } catch (\ReflectionException) {
-                    break; // method has no prototype
+                if (!$r->hasPrototype()) {
+                    break;
                 }
+                $r = $r->getPrototype();
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -57,11 +57,10 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed`
`57`	`57`	`}`
`58`	`58`	`break;`
`59`	`59`	`}`
`60`		`- try {`
`61`		`- $r = $r->getPrototype();`
`62`		`- } catch (\ReflectionException) {`
`63`		`- break; // method has no prototype`
	`60`	`+ if (!$r->hasPrototype()) {`
	`61`	`+ break;`
`64`	`62`	`}`
	`63`	`+ $r = $r->getPrototype();`
`65`	`64`	`}`
`66`	`65`	`}`
`67`	`66`